diff mbox

[01/17] cxgb3: handle global variables properly

Message ID 1476388576-22863-2-git-send-email-hch@lst.de (mailing list archive)
State Accepted
Headers show

Commit Message

Christoph Hellwig Oct. 13, 2016, 7:56 p.m. UTC
We'll need to define them in one compilation unit and use an extern
declaration in the headers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 providers/cxgb3/cxio_wr.h | 6 +++---
 providers/cxgb3/iwch.c    | 4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

Comments

Steve Wise Oct. 13, 2016, 9:58 p.m. UTC | #1
> 
> We'll need to define them in one compilation unit and use an extern
> declaration in the headers.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---

Looks good.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/providers/cxgb3/cxio_wr.h b/providers/cxgb3/cxio_wr.h
index e154795..d56c529 100644
--- a/providers/cxgb3/cxio_wr.h
+++ b/providers/cxgb3/cxio_wr.h
@@ -633,9 +633,9 @@  static inline unsigned t3_cq_depth(struct t3_cq *cq)
 	return (1UL<<cq->size_log2);
 }
 
-unsigned long iwch_page_size;
-unsigned long iwch_page_shift;
-unsigned long iwch_page_mask;
+extern unsigned long iwch_page_size;
+extern unsigned long iwch_page_shift;
+extern unsigned long iwch_page_mask;
 
 #define PAGE_ALIGN(x) (((x) + iwch_page_mask) & ~iwch_page_mask)
 
diff --git a/providers/cxgb3/iwch.c b/providers/cxgb3/iwch.c
index aa9b108..804726c 100644
--- a/providers/cxgb3/iwch.c
+++ b/providers/cxgb3/iwch.c
@@ -105,6 +105,10 @@  static struct ibv_context_ops iwch_ctx_ops = {
 	.req_notify_cq = iwch_arm_cq,
 };
 
+unsigned long iwch_page_size;
+unsigned long iwch_page_shift;
+unsigned long iwch_page_mask;
+
 static struct ibv_context *iwch_alloc_context(struct ibv_device *ibdev,
 					      int cmd_fd)
 {