| Message ID | 1477318892-22877-1-git-send-email-akarwar@marvell.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Mon, Oct 24, 2016 at 07:51:28PM +0530, Amitkumar Karwar wrote: > This condition while calling mwifiex_check_ps_cond() is redundant. > The function internally already takes care of it. > > Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> Unless you're intentionally *not* logging the "Delay Sleep Confirm" in some cases, this looks good: Reviewed-by: Brian Norris <briannorris@chromium.org> > --- > drivers/net/wireless/marvell/mwifiex/main.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c > index 2478ccd..3b31ea2 100644 > --- a/drivers/net/wireless/marvell/mwifiex/main.c > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > @@ -355,10 +355,8 @@ process_start: > > /* Check if we need to confirm Sleep Request > received previously */ > - if (adapter->ps_state == PS_STATE_PRE_SLEEP) { > - if (!adapter->cmd_sent && !adapter->curr_cmd) > - mwifiex_check_ps_cond(adapter); > - } > + if (adapter->ps_state == PS_STATE_PRE_SLEEP) > + mwifiex_check_ps_cond(adapter); > > /* * The ps_state may have been changed during processing of > * Sleep Request event. > -- > 1.9.1 >
diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c index 2478ccd..3b31ea2 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.c +++ b/drivers/net/wireless/marvell/mwifiex/main.c @@ -355,10 +355,8 @@ process_start: /* Check if we need to confirm Sleep Request received previously */ - if (adapter->ps_state == PS_STATE_PRE_SLEEP) { - if (!adapter->cmd_sent && !adapter->curr_cmd) - mwifiex_check_ps_cond(adapter); - } + if (adapter->ps_state == PS_STATE_PRE_SLEEP) + mwifiex_check_ps_cond(adapter); /* * The ps_state may have been changed during processing of * Sleep Request event.
This condition while calling mwifiex_check_ps_cond() is redundant. The function internally already takes care of it. Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> --- drivers/net/wireless/marvell/mwifiex/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)