Message ID | 1477575407-20562-2-git-send-email-leon@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
On Thu, Oct 27, 2016 at 4:36 PM, Leon Romanovsky <leon@kernel.org> wrote: > From: Max Gurtovoy <maxg@mellanox.com> > > Replace the pre-defined macro signifying inline umr instead > of the numerical constant. Leon, By all means (or no means, choose), this is a fix. If you are telling vmware and Broadcom people here for months how to write their code, let's stop for a minute and look in the mirror, drop this patch. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 28, 2016 at 03:54:25PM +0300, Or Gerlitz wrote: > On Thu, Oct 27, 2016 at 4:36 PM, Leon Romanovsky <leon@kernel.org> wrote: > > From: Max Gurtovoy <maxg@mellanox.com> > > > > Replace the pre-defined macro signifying inline umr instead > > of the numerical constant. > > Leon, > > By all means (or no means, choose), this is a fix. If you are telling > vmware and Broadcom people here for months how to write their code, > let's stop for a minute and look in the mirror, drop this patch. Thanks Or, I appreciate your time invested in the review and providing so much valuable feedback. Since change of numeric value to the same value defined by macro is not a fix but improvement and provided here to simplify maintainer's work (Doug), I have no plans to change the patch or/and drop it. > > Or. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 28, 2016 at 5:55 PM, Leon Romanovsky <leonro@mellanox.com> wrote: > On Fri, Oct 28, 2016 at 03:54:25PM +0300, Or Gerlitz wrote: >> By all means (or no means, choose), this is a fix. If you are telling > Since change of numeric value to the same value defined by macro is not > a fix but improvement [..] I have no plans to change the patch or/and drop it. RU listening? it's a -next patch, not rc -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 41f4c2a..00cffbf 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -3068,7 +3068,7 @@ static void set_linv_umr_seg(struct mlx5_wqe_umr_ctrl_seg *umr) { memset(umr, 0, sizeof(*umr)); umr->mkey_mask = cpu_to_be64(MLX5_MKEY_MASK_FREE); - umr->flags = 1 << 7; + umr->flags = MLX5_UMR_INLINE; } static __be64 get_umr_reg_mr_mask(void)