diff mbox

ARM: spi: rewrites the name of the function.

Message ID 1478480410-6320-1-git-send-email-cm-hiep@jinso.co.jp (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Cao Minh Hiep Nov. 7, 2016, 1 a.m. UTC 
From: Hiep Cao Minh <cm-hiep@jinso.co.jp>

This patch rewrites the name of rspi_pio_transfer_in_or_out
function.

Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
---
 drivers/spi/spi-rspi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Geert Uytterhoeven Nov. 7, 2016, 10:25 a.m. UTC | #1 
Hi Hiep,

On Mon, Nov 7, 2016 at 2:00 AM, Cao Minh Hiep <cm-hiep@jinso.co.jp> wrote:
> From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>
> This patch rewrites the name of rspi_pio_transfer_in_or_out
> function.
>
> Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

But you want to use proper prefixes matching the style of the subsystem,
to avoid Mark's canned message reply system.

Always use e.g. "git log --oneline drivers/spi/spi-rspi.c" to find out...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Cao Minh Hiep Nov. 8, 2016, 12:17 a.m. UTC | #2 
Hi Geert,

Thanks for your comment.

On 11/07/2016 07:25 PM, Geert Uytterhoeven wrote:
> Hi Hiep,
>
> On Mon, Nov 7, 2016 at 2:00 AM, Cao Minh Hiep <cm-hiep@jinso.co.jp> wrote:
>> From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>>
>> This patch rewrites the name of rspi_pio_transfer_in_or_out
>> function.
>>
>> Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> But you want to use proper prefixes matching the style of the subsystem,
> to avoid Mark's canned message reply system.
>
> Always use e.g. "git log --oneline drivers/spi/spi-rspi.c" to find out...
Thanks, I will make matching the style of the subsystem.

Jinzai Solution.
Hiep.

> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds
>
diff mbox

Patch

diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
index fb12bc5..7d3a825 100644
--- a/drivers/spi/spi-rspi.c
+++ b/drivers/spi/spi-rspi.c
@@ -515,7 +515,7 @@  static int rspi_pio_transfer(struct rspi_data *rspi, const u8 *tx, u8 *rx,
 	return 0;
 }
 
-static int rspi_pio_transfer_in_or_our(struct rspi_data *rspi, const u8 *tx, 
+static int rspi_pio_transfer_in_or_out(struct rspi_data *rspi, const u8 *tx, 
 				       u8 *rx, unsigned int n)
 {
 	unsigned int i, len;
@@ -839,7 +839,7 @@  static int qspi_transfer_out(struct rspi_data *rspi, struct spi_transfer *xfer)
 			return ret;
 	}
 
-	ret = rspi_pio_transfer_in_or_our(rspi, xfer->tx_buf, NULL, xfer->len);
+	ret = rspi_pio_transfer_in_or_out(rspi, xfer->tx_buf, NULL, xfer->len);
 	if (ret < 0)
 		return ret;
 
@@ -857,7 +857,7 @@  static int qspi_transfer_in(struct rspi_data *rspi, struct spi_transfer *xfer)
 			return ret;
 	}
 
-	return rspi_pio_transfer_in_or_our(rspi, NULL, xfer->rx_buf, xfer->len);
+	return rspi_pio_transfer_in_or_out(rspi, NULL, xfer->rx_buf, xfer->len);
 }
 
 static int qspi_transfer_one(struct spi_master *master, struct spi_device *spi,