| Message ID | 1477559563-18328-1-git-send-email-akarwar@marvell.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thu, Oct 27, 2016 at 02:42:39PM +0530, Amitkumar Karwar wrote: > This condition while calling mwifiex_check_ps_cond() is redundant. > The function internally already takes care of it. > > Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> > --- > v2: Same as v1 You've omitted the Reviewed-by tags from v1: Reviewed-by: Brian Norris <briannorris@chromium.org>
Hi, We have include below change in latest submit https://patchwork.kernel.org/patch/9407283/ Please drop this patch. > -----Original Message----- > From: linux-wireless-owner@vger.kernel.org > [mailto:linux-wireless-owner@vger.kernel.org] On Behalf Of Brian Norris > Sent: 2016年10月28日 2:36 > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > rajatja@google.com; briannorris@google.com; dmitry.torokhov@gmail.com > Subject: Re: [PATCH v2 1/5] mwifiex: remove redundant condition in main > process > > On Thu, Oct 27, 2016 at 02:42:39PM +0530, Amitkumar Karwar wrote: > > This condition while calling mwifiex_check_ps_cond() is redundant. > > The function internally already takes care of it. > > > > Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> > > --- > > v2: Same as v1 > > You've omitted the Reviewed-by tags from v1: > > Reviewed-by: Brian Norris <briannorris@chromium.org>
Xinming Hu <huxm@marvell.com> writes: > We have include below change in latest submit https://patchwork.kernel.org/patch/9407283/ > Please drop this patch. When making changes please resend the whole patchset. I do not want to individually pick patches from different places, that will eventually go wrong anyway. So I just apply full patchsets.
On Mon, Nov 07, 2016 at 08:46:41PM +0200, Kalle Valo wrote: > Xinming Hu <huxm@marvell.com> writes: > > > We have include below change in latest submit https://patchwork.kernel.org/patch/9407283/ > > Please drop this patch. > > When making changes please resend the whole patchset. I do not want to > individually pick patches from different places, that will eventually go > wrong anyway. So I just apply full patchsets. I'm going to assume that Xinming intended that the entire series be resent, possibly without this patch. There were enough other issues in the series anyway. Brian
Hi Brian, > From: Brian Norris [mailto:briannorris@chromium.org] > Sent: Friday, November 11, 2016 1:17 AM > To: Kalle Valo > Cc: Xinming Hu; Amitkumar Karwar; linux-wireless@vger.kernel.org; Cathy > Luo; Nishant Sarmukadam; rajatja@google.com; dmitry.torokhov@gmail.com > Subject: Re: [PATCH v2 1/5] mwifiex: remove redundant condition in main > process > > On Mon, Nov 07, 2016 at 08:46:41PM +0200, Kalle Valo wrote: > > Xinming Hu <huxm@marvell.com> writes: > > > > > We have include below change in latest submit > > > https://patchwork.kernel.org/patch/9407283/ > > > Please drop this patch. > > > > When making changes please resend the whole patchset. I do not want > to > > individually pick patches from different places, that will eventually > > go wrong anyway. So I just apply full patchsets. > > I'm going to assume that Xinming intended that the entire series be > resent, possibly without this patch. There were enough other issues in > the series anyway. I will submit v3 series shortly. Regards, Amitkumar
diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c index 2478ccd..3b31ea2 100644 --- a/drivers/net/wireless/marvell/mwifiex/main.c +++ b/drivers/net/wireless/marvell/mwifiex/main.c @@ -355,10 +355,8 @@ process_start: /* Check if we need to confirm Sleep Request received previously */ - if (adapter->ps_state == PS_STATE_PRE_SLEEP) { - if (!adapter->cmd_sent && !adapter->curr_cmd) - mwifiex_check_ps_cond(adapter); - } + if (adapter->ps_state == PS_STATE_PRE_SLEEP) + mwifiex_check_ps_cond(adapter); /* * The ps_state may have been changed during processing of * Sleep Request event.
This condition while calling mwifiex_check_ps_cond() is redundant. The function internally already takes care of it. Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> --- v2: Same as v1 --- drivers/net/wireless/marvell/mwifiex/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)