| Message ID | 1478791145-21137-1-git-send-email-weiyj.lk@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On 10 November 2016 at 07:19, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fixes the following sparse warning: > > drivers/cpufreq/brcmstb-avs-cpufreq.c:982:18: warning: > symbol 'brcm_avs_cpufreq_attr' was not declared. Should it be static? Yes, thanks for the fix. Acked-by: Markus Mayer <mmayer@broadcom.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c > index b761d54..4fda623 100644 > --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c > +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c > @@ -979,7 +979,7 @@ cpufreq_freq_attr_ro(brcm_avs_pmap); > cpufreq_freq_attr_ro(brcm_avs_voltage); > cpufreq_freq_attr_ro(brcm_avs_frequency); > > -struct freq_attr *brcm_avs_cpufreq_attr[] = { > +static struct freq_attr *brcm_avs_cpufreq_attr[] = { > &cpufreq_freq_attr_scaling_available_freqs, > &brcm_avs_pstate, > &brcm_avs_mode, > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10-11-16, 15:19, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fixes the following sparse warning: > > drivers/cpufreq/brcmstb-avs-cpufreq.c:982:18: warning: > symbol 'brcm_avs_cpufreq_attr' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c > index b761d54..4fda623 100644 > --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c > +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c > @@ -979,7 +979,7 @@ cpufreq_freq_attr_ro(brcm_avs_pmap); > cpufreq_freq_attr_ro(brcm_avs_voltage); > cpufreq_freq_attr_ro(brcm_avs_frequency); > > -struct freq_attr *brcm_avs_cpufreq_attr[] = { > +static struct freq_attr *brcm_avs_cpufreq_attr[] = { > &cpufreq_freq_attr_scaling_available_freqs, > &brcm_avs_pstate, > &brcm_avs_mode, Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Thursday, November 10, 2016 02:06:16 PM Markus Mayer wrote: > On 10 November 2016 at 07:19, Wei Yongjun <weiyj.lk@gmail.com> wrote: > > From: Wei Yongjun <weiyongjun1@huawei.com> > > > > Fixes the following sparse warning: > > > > drivers/cpufreq/brcmstb-avs-cpufreq.c:982:18: warning: > > symbol 'brcm_avs_cpufreq_attr' was not declared. Should it be static? > > Yes, thanks for the fix. > > Acked-by: Markus Mayer <mmayer@broadcom.com> Applied. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c index b761d54..4fda623 100644 --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c @@ -979,7 +979,7 @@ cpufreq_freq_attr_ro(brcm_avs_pmap); cpufreq_freq_attr_ro(brcm_avs_voltage); cpufreq_freq_attr_ro(brcm_avs_frequency); -struct freq_attr *brcm_avs_cpufreq_attr[] = { +static struct freq_attr *brcm_avs_cpufreq_attr[] = { &cpufreq_freq_attr_scaling_available_freqs, &brcm_avs_pstate, &brcm_avs_mode,