diff mbox

nfs-utils: start-statd script using incompatible file descriptor

Message ID 70eeb75e-e48f-fb0a-a690-1c6c8cb0ede4@pocock.pro (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Pocock Dec. 17, 2016, 11 a.m. UTC
The current script uses fd 200, doesn't work for every possible shell as
reported[1] in Debian bug #848277

We are including a patch for it in the 1.3.4-2 package, it would be good
to incorporate this patch upstream too.

Regards,

Daniel


1. https://bugs.debian.org/848277

Comments

Steve Dickson Dec. 17, 2016, 6:27 p.m. UTC | #1
Hello, 

Could up please resubmit this patch with the
proper patch description (basically what 
problem you are fixing) and a proper 
 Signed-off-by: line.

steved.

On 12/17/2016 06:00 AM, Daniel Pocock wrote:
> 
> 
> The current script uses fd 200, doesn't work for every possible shell as
> reported[1] in Debian bug #848277
> 
> We are including a patch for it in the 1.3.4-2 package, it would be good
> to incorporate this patch upstream too.
> 
> Regards,
> 
> Daniel
> 
> 
> 1. https://bugs.debian.org/848277
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve Dickson Dec. 20, 2016, 6:30 p.m. UTC | #2
On 12/17/2016 06:00 AM, Daniel Pocock wrote:
> 
> 
> The current script uses fd 200, doesn't work for every possible shell as
> reported[1] in Debian bug #848277
> 
> We are including a patch for it in the 1.3.4-2 package, it would be good
> to incorporate this patch upstream too.
> 
> Regards,
> 
> Daniel
> 
> 
> 1. https://bugs.debian.org/848277
> 
Committed... Next time please in line the patch
instead of attaching it. 

steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/statd/start-statd b/utils/statd/start-statd
index 2fd6039..82715b4 100755
--- a/utils/statd/start-statd
+++ b/utils/statd/start-statd
@@ -7,8 +7,8 @@ 
 PATH="/sbin:/usr/sbin:/bin:/usr/bin"
 
 # Use flock to serialize the running of this script
-exec 200> /var/run/rpc.statd.lock
-flock -e 200
+exec 9> /var/run/rpc.statd.lock
+flock -e 9
 
 if [ -s /var/run/rpc.statd.pid ] &&
        [ 1`cat /var/run/rpc.statd.pid` -gt 1 ] &&