diff mbox

mkfs.xfs: fix static-lib build

Message ID 20161017191327.16838-1-tytso@mit.edu (mailing list archive)
State Superseded
Headers show

Commit Message

Theodore Ts'o Oct. 17, 2016, 7:13 p.m. UTC 
From: Dmitry Monakhov <dmonakhov@openvz.org>

Order is important for static libraries, libblkid depends on libuuid.
We have to pass libuuid after libblkid, otherwise it fails like this:
#make mkfs.xfs
    [LD]     mkfs.xfs
    /bin/bash ../libtool --quiet --tag=CC --mode=link gcc -o mkfs.xfs -static -L/devel/xfstests-bld.git/bld/lib -static-libtool-libs  maxtrres.o proto.o xfs_mkfs.o   ../libxfs/libxfs.la ../libxcmd/libxcmd.la -luuid -lrt -lpthread -lblkid
    /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `set_uuid':
    /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:132: undefined reference to `uuid_is_null'
    /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:133: undefined reference to `uuid_unparse'
    /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `get_ext2_info':
    /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:156: undefined reference to `uuid_is_null'
    collect2: error: ld returned 1 exit status
    ../include/buildrules:45: recipe for target 'mkfs.xfs' failed
    make: *** [mkfs.xfs] Error 1

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 mkfs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dave Chinner Oct. 17, 2016, 10:40 p.m. UTC | #1 
On Mon, Oct 17, 2016 at 03:13:27PM -0400, Theodore Ts'o wrote:
> From: Dmitry Monakhov <dmonakhov@openvz.org>
> 
> Order is important for static libraries, libblkid depends on libuuid.
> We have to pass libuuid after libblkid, otherwise it fails like this:

$ glo -n 1 mkfs/Makefile
9e1c66ca9cee mkfs: fix library ordering
$ git describe --contains 9e1c66ca9cee
v4.8.0-rc1~49
$

Cheers,

Dave.
Theodore Ts'o Oct. 18, 2016, 2:14 a.m. UTC | #2 
On Tue, Oct 18, 2016 at 09:40:42AM +1100, Dave Chinner wrote:
> On Mon, Oct 17, 2016 at 03:13:27PM -0400, Theodore Ts'o wrote:
> > From: Dmitry Monakhov <dmonakhov@openvz.org>
> > 
> > Order is important for static libraries, libblkid depends on libuuid.
> > We have to pass libuuid after libblkid, otherwise it fails like this:
> 
> $ glo -n 1 mkfs/Makefile
> 9e1c66ca9cee mkfs: fix library ordering
> $ git describe --contains 9e1c66ca9cee
> v4.8.0-rc1~49
> $

My bad, I still have a repo which is tracking the xfsprogs git tree on
oss.sgi.com instead of git.kernel.org.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/mkfs/Makefile b/mkfs/Makefile
index 170e3c1..c13b903 100644
--- a/mkfs/Makefile
+++ b/mkfs/Makefile
@@ -10,7 +10,7 @@  LTCOMMAND = mkfs.xfs
 HFILES =
 CFILES = maxtrres.c proto.c xfs_mkfs.c
 
-LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID)
+LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID) $(LIBUUID)
 LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD)
 LLDFLAGS = -static-libtool-libs