| Message ID | 1483044517-5770-10-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi On Thu, Dec 29, 2016 at 9:48 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > We forgot to clean this up when adding connector refcounting. > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_atomic_helper.c | 5 ----- > 1 file changed, 5 deletions(-) Patch 1-10 all: Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Thanks David > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 8eab8944c736..5e5224460042 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -3286,11 +3286,6 @@ EXPORT_SYMBOL(drm_atomic_helper_duplicate_state); > void > __drm_atomic_helper_connector_destroy_state(struct drm_connector_state *state) > { > - /* > - * This is currently a placeholder so that drivers that subclass the > - * state will automatically do the right thing if code is ever added > - * to this function. > - */ > if (state->crtc) > drm_connector_unreference(state->connector); > } > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Dec 30, 2016 at 12:18:33PM +0100, David Herrmann wrote: > Hi > > On Thu, Dec 29, 2016 at 9:48 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > We forgot to clean this up when adding connector refcounting. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > --- > > drivers/gpu/drm/drm_atomic_helper.c | 5 ----- > > 1 file changed, 5 deletions(-) > > Patch 1-10 all: > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> All applied, thanks a lot for your review. -Daniel > > Thanks > David > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > > index 8eab8944c736..5e5224460042 100644 > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > @@ -3286,11 +3286,6 @@ EXPORT_SYMBOL(drm_atomic_helper_duplicate_state); > > void > > __drm_atomic_helper_connector_destroy_state(struct drm_connector_state *state) > > { > > - /* > > - * This is currently a placeholder so that drivers that subclass the > > - * state will automatically do the right thing if code is ever added > > - * to this function. > > - */ > > if (state->crtc) > > drm_connector_unreference(state->connector); > > } > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 8eab8944c736..5e5224460042 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3286,11 +3286,6 @@ EXPORT_SYMBOL(drm_atomic_helper_duplicate_state); void __drm_atomic_helper_connector_destroy_state(struct drm_connector_state *state) { - /* - * This is currently a placeholder so that drivers that subclass the - * state will automatically do the right thing if code is ever added - * to this function. - */ if (state->crtc) drm_connector_unreference(state->connector); }
We forgot to clean this up when adding connector refcounting. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/drm_atomic_helper.c | 5 ----- 1 file changed, 5 deletions(-)