| Message ID | 20170105011137.20209-1-lyude@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2017-01-05 at 09:52 +0100, Daniel Vetter wrote: > On Thu, Jan 05, 2017 at 10:41:07AM +0200, Jani Nikula wrote: > > No matter what we do here, the question remains what to do with > > Chamelium. Changing the color range is really a workaround for > > Chamelium, not a fix. Using CEA range is perfectly fine per DP > > spec. > Of course, I had just figured this was actually a bug, but I guess not :). I'll just make sure RGB Broadcast is set in the igt tests then > Can we just set a non-CEA mode/edid for chamelium, problem solved? We > want > to do that anyway for HDMI, where you really have to do the limited > range > dance to make stuff display correctly. > -Daniel
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index d9bc19b..6642abd 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1649,12 +1649,15 @@ intel_dp_compute_config(struct intel_encoder *encoder, found: if (intel_dp->color_range_auto) { /* + * We are required to use the limited CEA RGB range when a CEA + * mode is declared in the EDID. However, limiting the pixel + * value range is up to the sink, not the source. So, just + * don't enable limited color ranges. * See: * CEA-861-E - 5.1 Default Encoding Parameters * VESA DisplayPort Ver.1.2a - 5.1.1.1 Video Colorimetry */ - pipe_config->limited_color_range = - bpp != 18 && drm_match_cea_mode(adjusted_mode) > 1; + pipe_config->limited_color_range = false; } else { pipe_config->limited_color_range = intel_dp->limited_color_range;
Until now, it seems we've been erroneously enabling limited color ranges for the vast majority of DisplayPort monitors. I noticed this after writing a frame dump comparison test for the Chamelium and noticing that every i915 device I had was failing, while amdgpu machines were fine: https://people.freedesktop.org/~lyudess/archive/01-03-2017/ It looks like this is because the DisplayPort spec tells us to use limited color ranges whenever we detect a CEA mode in use. However, from the looks of it there's another rather confusing part of the spec that got missed: source devices are allowed to use the full range of values for pixels -even- if the sink device declares that it's using a CEA mode. It's up to the sink device to limit the pixel range to the CEA ranges if it needs. Signed-off-by: Lyude <lyude@redhat.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> --- I'm really surprised that this bug would have been around as long as it looks like it has been without anyone noticing it, so I figured I'd just send a patch to the mailing list so you guys can point out whether or not this is really the correct thing to do. drivers/gpu/drm/i915/intel_dp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)