[v4,2/2] ASoC: Intel: Use DMI name for sound card long name in Broadwell machine driver

Commit Message

[e-mail] Jan. 14, 2017, 8:13 a.m. UTC

From: Mengdong Lin <[e-mail]>

Intel Broadwell machine driver will call API snd_soc_set_dmi_name() to
use DMI info to make the sound card long name.

For example, here are the changed long name for two Broadwell-based
machines:
Dell XPS-13(2015): DellInc.-XPS139343-01-0310JH
Intel WilsonBeach: Intel Corp.-BroadwellClientplatform-0.1-WilsonBeachSDS

They still share the same card name "broadwell-rt286".

Signed-off-by: Mengdong Lin <[e-mail]>

Comments

Mark Brown Jan. 17, 2017, 5:56 p.m. UTC | #1

On Sat, Jan 14, 2017 at 04:13:09PM +0800, [e-mail] wrote:
> From: Mengdong Lin <[e-mail]>
> 
> Intel Broadwell machine driver will call API snd_soc_set_dmi_name() to
> use DMI info to make the sound card long name.

I guess we'll see further patches for other machine drivers?

Vinod Koul Jan. 18, 2017, 4:44 p.m. UTC | #2

On Tue, Jan 17, 2017 at 05:56:36PM +0000, Mark Brown wrote:
> On Sat, Jan 14, 2017 at 04:13:09PM +0800, [e-mail] wrote:
> > From: Mengdong Lin <[e-mail]>
> > 
> > Intel Broadwell machine driver will call API snd_soc_set_dmi_name() to
> > use DMI info to make the sound card long name.
> 
> I guess we'll see further patches for other machine drivers?

Yes that's the idea. At least we will convert the Skylake and Broxton ones,
after the current submitted patches and DP-MST ones are merged.

Thanks

Takashi Iwai Jan. 18, 2017, 4:50 p.m. UTC | #3

On Wed, 18 Jan 2017 17:44:59 +0100,
Vinod Koul wrote:
> 
> On Tue, Jan 17, 2017 at 05:56:36PM +0000, Mark Brown wrote:
> > On Sat, Jan 14, 2017 at 04:13:09PM +0800, [e-mail] wrote:
> > > From: Mengdong Lin <[e-mail]>
> > > 
> > > Intel Broadwell machine driver will call API snd_soc_set_dmi_name() to
> > > use DMI info to make the sound card long name.
> > 
> > I guess we'll see further patches for other machine drivers?
> 
> Yes that's the idea. At least we will convert the Skylake and Broxton ones,
> after the current submitted patches and DP-MST ones are merged.

I had an impression that rather BYT and CHT machines require urgently
this extension because there are quite lots of devices with the same
component but different configurations...


Takashi

Pierre-Louis Bossart Jan. 18, 2017, 5:23 p.m. UTC | #4

On 1/18/17 10:50 AM, Takashi Iwai wrote:
> On Wed, 18 Jan 2017 17:44:59 +0100,
> Vinod Koul wrote:
>> On Tue, Jan 17, 2017 at 05:56:36PM +0000, Mark Brown wrote:
>>> On Sat, Jan 14, 2017 at 04:13:09PM +0800, [e-mail] wrote:
>>>> From: Mengdong Lin <[e-mail]>
>>>>
>>>> Intel Broadwell machine driver will call API snd_soc_set_dmi_name() to
>>>> use DMI info to make the sound card long name.
>>> I guess we'll see further patches for other machine drivers?
>> Yes that's the idea. At least we will convert the Skylake and Broxton ones,
>> after the current submitted patches and DP-MST ones are merged.
> I had an impression that rather BYT and CHT machines require urgently
> this extension because there are quite lots of devices with the same
> component but different configurations...

My first priority is to close on the set of known quirks and contribute 
them once the reworked MCLK patches are merged. We can add the DMI name 
at the same time for BYT/CHT.
Note that adding the name in the machine driver is only the first part 
required to be able to manage quirks. it'll take a bit of time to 
convert the existing UCM files, make use of the include mechanism and 
contribute them to a repository with a faster update rate than alsa-lib.

Patch

diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c
index 5bb64d1..cda73bb 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -266,6 +266,8 @@  static int broadwell_audio_probe(struct platform_device *pdev)
 {
 	broadwell_rt286.dev = &pdev->dev;
 
+	snd_soc_set_dmi_name(&broadwell_rt286, NULL);
+
 	return devm_snd_soc_register_card(&pdev->dev, &broadwell_rt286);
 }