diff mbox

xfs_repair: Fix uninit var in process_leaf_attr_level

Message ID fe6cd162-4f2a-d470-f8ea-8a028a649212@redhat.com (mailing list archive)
State Accepted
Headers show

Commit Message

Eric Sandeen Jan. 26, 2017, 2:30 a.m. UTC 
My unreviewed maintainer adjustment on the way in gets a
brown paper bag.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Darrick J. Wong Jan. 26, 2017, 2:33 a.m. UTC | #1 
On Wed, Jan 25, 2017 at 08:30:05PM -0600, Eric Sandeen wrote:
> My unreviewed maintainer adjustment on the way in gets a
> brown paper bag.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
> 
> diff --git a/repair/attr_repair.c b/repair/attr_repair.c
> index 158e31a..9ec2231 100644
> --- a/repair/attr_repair.c
> +++ b/repair/attr_repair.c
> @@ -753,6 +753,7 @@ process_leaf_attr_level(xfs_mount_t	*mp,
>  	struct xfs_attr3_icleaf_hdr leafhdr;
>  
>  	da_bno = da_cursor->level[0].bno;
> +	ino = da_cursor->ino;
>  	/*
>  	 * 0 is the root block and no block
>  	 * pointer can point to the root block of the btree
> @@ -764,7 +765,6 @@ process_leaf_attr_level(xfs_mount_t	*mp,
>  		goto error_out;
>  	}
>  
> -	ino = da_cursor->ino;
>  	prev_bno = 0;
>  
>  	do {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/repair/attr_repair.c b/repair/attr_repair.c
index 158e31a..9ec2231 100644
--- a/repair/attr_repair.c
+++ b/repair/attr_repair.c
@@ -753,6 +753,7 @@  process_leaf_attr_level(xfs_mount_t	*mp,
 	struct xfs_attr3_icleaf_hdr leafhdr;
 
 	da_bno = da_cursor->level[0].bno;
+	ino = da_cursor->ino;
 	/*
 	 * 0 is the root block and no block
 	 * pointer can point to the root block of the btree
@@ -764,7 +765,6 @@  process_leaf_attr_level(xfs_mount_t	*mp,
 		goto error_out;
 	}
 
-	ino = da_cursor->ino;
 	prev_bno = 0;
 
 	do {