Message ID | 20170217130557.6710-3-arkadiusz.hiler@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote: I think one line with description will not kill us ;) Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > --- > drivers/gpu/drm/i915/intel_uc.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h > index dd34a1b..41b7351 100644 > --- a/drivers/gpu/drm/i915/intel_uc.h > +++ b/drivers/gpu/drm/i915/intel_uc.h > @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len); > int intel_guc_sample_forcewake(struct intel_guc *guc); > > /* intel_guc_loader.c */ > -extern void intel_guc_init(struct drm_i915_private *dev_priv); > -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv); > -extern void intel_guc_fini(struct drm_i915_private *dev_priv); > -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); > -extern int intel_guc_suspend(struct drm_i915_private *dev_priv); > -extern int intel_guc_resume(struct drm_i915_private *dev_priv); > +void intel_guc_init(struct drm_i915_private *dev_priv); > +int intel_guc_init_hw(struct drm_i915_private *dev_priv); > +void intel_guc_fini(struct drm_i915_private *dev_priv); > +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); > +int intel_guc_suspend(struct drm_i915_private *dev_priv); > +int intel_guc_resume(struct drm_i915_private *dev_priv); > void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, > struct intel_uc_fw *uc_fw); > u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv); > -- > 2.9.3 >
On Fri, Feb 17, 2017 at 02:13:06PM +0100, Michal Wajdeczko wrote: > On Fri, Feb 17, 2017 at 02:05:51PM +0100, Arkadiusz Hiler wrote: > > I think one line with description will not kill us ;) Comment title is exactly that. If you have something that won't be just simple restatement of the title / saying what this trivial diff says then please share. > Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Thanks. > > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > > --- > > drivers/gpu/drm/i915/intel_uc.h | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h > > index dd34a1b..41b7351 100644 > > --- a/drivers/gpu/drm/i915/intel_uc.h > > +++ b/drivers/gpu/drm/i915/intel_uc.h > > @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len); > > int intel_guc_sample_forcewake(struct intel_guc *guc); > > > > /* intel_guc_loader.c */ > > -extern void intel_guc_init(struct drm_i915_private *dev_priv); > > -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv); > > -extern void intel_guc_fini(struct drm_i915_private *dev_priv); > > -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); > > -extern int intel_guc_suspend(struct drm_i915_private *dev_priv); > > -extern int intel_guc_resume(struct drm_i915_private *dev_priv); > > +void intel_guc_init(struct drm_i915_private *dev_priv); > > +int intel_guc_init_hw(struct drm_i915_private *dev_priv); > > +void intel_guc_fini(struct drm_i915_private *dev_priv); > > +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); > > +int intel_guc_suspend(struct drm_i915_private *dev_priv); > > +int intel_guc_resume(struct drm_i915_private *dev_priv); > > void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, > > struct intel_uc_fw *uc_fw); > > u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv); > > -- > > 2.9.3 > >
diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h index dd34a1b..41b7351 100644 --- a/drivers/gpu/drm/i915/intel_uc.h +++ b/drivers/gpu/drm/i915/intel_uc.h @@ -189,12 +189,12 @@ int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len); int intel_guc_sample_forcewake(struct intel_guc *guc); /* intel_guc_loader.c */ -extern void intel_guc_init(struct drm_i915_private *dev_priv); -extern int intel_guc_init_hw(struct drm_i915_private *dev_priv); -extern void intel_guc_fini(struct drm_i915_private *dev_priv); -extern const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); -extern int intel_guc_suspend(struct drm_i915_private *dev_priv); -extern int intel_guc_resume(struct drm_i915_private *dev_priv); +void intel_guc_init(struct drm_i915_private *dev_priv); +int intel_guc_init_hw(struct drm_i915_private *dev_priv); +void intel_guc_fini(struct drm_i915_private *dev_priv); +const char *intel_uc_fw_status_repr(enum intel_uc_fw_status status); +int intel_guc_suspend(struct drm_i915_private *dev_priv); +int intel_guc_resume(struct drm_i915_private *dev_priv); void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, struct intel_uc_fw *uc_fw); u32 intel_guc_wopcm_size(struct drm_i915_private *dev_priv);
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> --- drivers/gpu/drm/i915/intel_uc.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)