diff mbox

[3/4] fpga dt: bindings for Altera Partial Reconfiguraion IP.

Message ID 1487193038-3490-4-git-send-email-matthew.gerlach@linux.intel.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Matthew Gerlach Feb. 15, 2017, 9:10 p.m. UTC
From: Matthew Gerlach <matthew.gerlach@linux.intel.com>

Device Tree bindings for Altera Partial Reconfiguraion IP?

Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
---
 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt

Comments

Dinh Nguyen Feb. 17, 2017, 1:31 p.m. UTC | #1
On Wed, Feb 15, 2017 at 3:10 PM,  <matthew.gerlach@linux.intel.com> wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Device Tree bindings for Altera Partial Reconfiguraion IP?
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
>  Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
>

Nit: your commit header s/Reconfiguraion/Reconfiguration

Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Moritz Fischer Feb. 17, 2017, 3:20 p.m. UTC | #2
Matthew,

On Fri, Feb 17, 2017 at 5:31 AM, Dinh Nguyen <dinh.linux@gmail.com> wrote:
> On Wed, Feb 15, 2017 at 3:10 PM,  <matthew.gerlach@linux.intel.com> wrote:
>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>
>> Device Tree bindings for Altera Partial Reconfiguraion IP?
>>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Acked-By: Moritz Fischer <mdf@kernel.org>
>> ---
>>  Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
>>
>
> Nit: your commit header s/Reconfiguraion/Reconfiguration
>
> Dinh

Thanks,
Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring (Arm) Feb. 27, 2017, 2:32 p.m. UTC | #3
On Wed, Feb 15, 2017 at 01:10:37PM -0800, matthew.gerlach@linux.intel.com wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> 
> Device Tree bindings for Altera Partial Reconfiguraion IP?
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
>  Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
> 
> diff --git a/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
> new file mode 100644
> index 0000000..ada821f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
> @@ -0,0 +1,12 @@
> +Altera Partial Reconfiguration IP
> +
> +Required properties:
> +- compatible : should contain "altr,pr-ip"

Kind of generic. There's only one version of h/w?

> +- reg        : base address and size for memory mapped io.
> +
> +Example:
> +
> +	fpga_mgr: fpga-mgr@ff20c000 {
> +		compatible = "altr,pr-ip";
> +		reg = <0xff20c000 0x10>;
> +	};
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matthew Gerlach Feb. 27, 2017, 4:27 p.m. UTC | #4
On Mon, 27 Feb 2017, Rob Herring wrote:

Hi Rob,


> On Wed, Feb 15, 2017 at 01:10:37PM -0800, matthew.gerlach@linux.intel.com wrote:
>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>
>> Device Tree bindings for Altera Partial Reconfiguraion IP?
>>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>> ---
>>  Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
>>
>> diff --git a/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
>> new file mode 100644
>> index 0000000..ada821f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
>> @@ -0,0 +1,12 @@
>> +Altera Partial Reconfiguration IP
>> +
>> +Required properties:
>> +- compatible : should contain "altr,pr-ip"
>
> Kind of generic. There's only one version of h/w?


Fair point on being generic.  It does match the published documentation, 
but we could be more specific with "altr,a10-pr-ip" because it 
really is only for an Arria10.

Matthew Gerlach

>
>> +- reg        : base address and size for memory mapped io.
>> +
>> +Example:
>> +
>> +	fpga_mgr: fpga-mgr@ff20c000 {
>> +		compatible = "altr,pr-ip";
>> +		reg = <0xff20c000 0x10>;
>> +	};
>> --
>> 2.7.4
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
new file mode 100644
index 0000000..ada821f
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/altera-pr-ip.txt
@@ -0,0 +1,12 @@ 
+Altera Partial Reconfiguration IP
+
+Required properties:
+- compatible : should contain "altr,pr-ip"
+- reg        : base address and size for memory mapped io.
+
+Example:
+
+	fpga_mgr: fpga-mgr@ff20c000 {
+		compatible = "altr,pr-ip";
+		reg = <0xff20c000 0x10>;
+	};