| Message ID | 20170217143945.2217431-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote: > I ran into a build error on arm64 randconfig testing: > > infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has > no type or storage class [-Werror] > infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to > 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] > infiniband/hw/hns/hns_roce_main.c:539:1: error: parameter names > (without types) in function declaration [-Werror] > infiniband/hw/hns/hns_roce_main.c:979:226: error: data definition has > no type or storage class [-Werror] > infiniband/hw/hns/hns_roce_main.c:979:226: error: type defaults to > 'int' in declaration of 'module_init' [-Werror=implicit-int] > infiniband/hw/hns/hns_roce_main.c:979:1: error: parameter names > (without types) in function declaration [-Werror] > > Including the module.h makes it build again. > > Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, applied.
diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index 4953d9cb83a7..cf14679664ca 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -32,6 +32,7 @@ */ #include <linux/acpi.h> #include <linux/of_platform.h> +#include <linux/module.h> #include <rdma/ib_addr.h> #include <rdma/ib_smi.h> #include <rdma/ib_user_verbs.h>
I ran into a build error on arm64 randconfig testing: infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has no type or storage class [-Werror] infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] infiniband/hw/hns/hns_roce_main.c:539:1: error: parameter names (without types) in function declaration [-Werror] infiniband/hw/hns/hns_roce_main.c:979:226: error: data definition has no type or storage class [-Werror] infiniband/hw/hns/hns_roce_main.c:979:226: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] infiniband/hw/hns/hns_roce_main.c:979:1: error: parameter names (without types) in function declaration [-Werror] Including the module.h makes it build again. Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/infiniband/hw/hns/hns_roce_main.c | 1 + 1 file changed, 1 insertion(+)