Message ID | 20170301223915.29888-2-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Laurent, On 01-03-2017 22:39, Laurent Pinchart wrote: > Most of the hdmi_phy_test_*() functions are unused. Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Jose Abreu <joabreu@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c > index 9a9ec27d9e28..ce7496399ccf 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -837,32 +837,6 @@ static inline void hdmi_phy_test_clear(struct dw_hdmi *hdmi, > HDMI_PHY_TST0_TSTCLR_MASK, HDMI_PHY_TST0); > } > > -static inline void hdmi_phy_test_enable(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTEN_OFFSET, > - HDMI_PHY_TST0_TSTEN_MASK, HDMI_PHY_TST0); > -} > - > -static inline void hdmi_phy_test_clock(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLK_OFFSET, > - HDMI_PHY_TST0_TSTCLK_MASK, HDMI_PHY_TST0); > -} > - > -static inline void hdmi_phy_test_din(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_writeb(hdmi, bit, HDMI_PHY_TST1); > -} > - > -static inline void hdmi_phy_test_dout(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_writeb(hdmi, bit, HDMI_PHY_TST2); > -} > - > static bool hdmi_phy_wait_i2c_done(struct dw_hdmi *hdmi, int msec) > { > u32 val;
Hi Laurent, 在 2017年03月02日 06:39, Laurent Pinchart 写道: > Most of the hdmi_phy_test_*() functions are unused. Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Tested-by: Nickey Yang <nickey.yang@rock-chips.com> Best regards, Nickey Yang > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c > index 9a9ec27d9e28..ce7496399ccf 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -837,32 +837,6 @@ static inline void hdmi_phy_test_clear(struct dw_hdmi *hdmi, > HDMI_PHY_TST0_TSTCLR_MASK, HDMI_PHY_TST0); > } > > -static inline void hdmi_phy_test_enable(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTEN_OFFSET, > - HDMI_PHY_TST0_TSTEN_MASK, HDMI_PHY_TST0); > -} > - > -static inline void hdmi_phy_test_clock(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLK_OFFSET, > - HDMI_PHY_TST0_TSTCLK_MASK, HDMI_PHY_TST0); > -} > - > -static inline void hdmi_phy_test_din(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_writeb(hdmi, bit, HDMI_PHY_TST1); > -} > - > -static inline void hdmi_phy_test_dout(struct dw_hdmi *hdmi, > - unsigned char bit) > -{ > - hdmi_writeb(hdmi, bit, HDMI_PHY_TST2); > -} > - > static bool hdmi_phy_wait_i2c_done(struct dw_hdmi *hdmi, int msec) > { > u32 val;
diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 9a9ec27d9e28..ce7496399ccf 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/dw-hdmi.c @@ -837,32 +837,6 @@ static inline void hdmi_phy_test_clear(struct dw_hdmi *hdmi, HDMI_PHY_TST0_TSTCLR_MASK, HDMI_PHY_TST0); } -static inline void hdmi_phy_test_enable(struct dw_hdmi *hdmi, - unsigned char bit) -{ - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTEN_OFFSET, - HDMI_PHY_TST0_TSTEN_MASK, HDMI_PHY_TST0); -} - -static inline void hdmi_phy_test_clock(struct dw_hdmi *hdmi, - unsigned char bit) -{ - hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLK_OFFSET, - HDMI_PHY_TST0_TSTCLK_MASK, HDMI_PHY_TST0); -} - -static inline void hdmi_phy_test_din(struct dw_hdmi *hdmi, - unsigned char bit) -{ - hdmi_writeb(hdmi, bit, HDMI_PHY_TST1); -} - -static inline void hdmi_phy_test_dout(struct dw_hdmi *hdmi, - unsigned char bit) -{ - hdmi_writeb(hdmi, bit, HDMI_PHY_TST2); -} - static bool hdmi_phy_wait_i2c_done(struct dw_hdmi *hdmi, int msec) { u32 val;
Most of the hdmi_phy_test_*() functions are unused. Remove them. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpu/drm/bridge/dw-hdmi.c | 26 -------------------------- 1 file changed, 26 deletions(-)