| Message ID | 5780384b-87ef-fb39-6804-35f7eaada0c7@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Mar 08, 2017 at 01:48:46PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 7 Mar 2017 19:25:55 +0100 > > The local variables "req" and "rsp" will be set to appropriate pointers > a bit later. Thus omit the explicit initialisations at the beginning. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index 85bebb887c5c..517a18e9351a 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -2895,9 +2895,8 @@ static int ocrdma_mbx_get_dcbx_config(struct ocrdma_dev *dev, u32 ptype, > int status; > dma_addr_t pa; > struct ocrdma_mqe cmd; > - > - struct ocrdma_get_dcbx_cfg_req *req = NULL; > - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL; > + struct ocrdma_get_dcbx_cfg_req *req; > + struct ocrdma_get_dcbx_cfg_rsp *rsp; Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > struct pci_dev *pdev = dev->nic_info.pdev; > struct ocrdma_mqe_sge *mqe_sge = cmd.u.nonemb_req.sge; > > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c index 85bebb887c5c..517a18e9351a 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c @@ -2895,9 +2895,8 @@ static int ocrdma_mbx_get_dcbx_config(struct ocrdma_dev *dev, u32 ptype, int status; dma_addr_t pa; struct ocrdma_mqe cmd; - - struct ocrdma_get_dcbx_cfg_req *req = NULL; - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL; + struct ocrdma_get_dcbx_cfg_req *req; + struct ocrdma_get_dcbx_cfg_rsp *rsp; struct pci_dev *pdev = dev->nic_info.pdev; struct ocrdma_mqe_sge *mqe_sge = cmd.u.nonemb_req.sge;