| Message ID | dd638070-d1d6-44e8-6c10-16919b59482c@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Acked-By:Devesh Sharma <devesh.sharma@broadcom.com> On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 8 Mar 2017 10:48:24 +0100 > > Return constant integer values without storing them in the local > variable "status". > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index bedc229be89d..1d25512416f5 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev, > int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt, > struct ib_udata *udata) > { > - int status = 0; > struct ocrdma_cq *cq = get_ocrdma_cq(ibcq); > > - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) { > - status = -EINVAL; > - return status; > - } > + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) > + return -EINVAL; > ibcq->cqe = new_cnt; > - return status; > + return 0; > } > > static void ocrdma_flush_cq(struct ocrdma_cq *cq) > -- > 2.12.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 08, 2017 at 02:26:16PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 8 Mar 2017 10:48:24 +0100 > > Return constant integer values without storing them in the local > variable "status". > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index bedc229be89d..1d25512416f5 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev, > int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt, > struct ib_udata *udata) > { > - int status = 0; > struct ocrdma_cq *cq = get_ocrdma_cq(ibcq); > > - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) { > - status = -EINVAL; > - return status; > - } > + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) > + return -EINVAL; > ibcq->cqe = new_cnt; > - return status; > + return 0; Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > } > > static void ocrdma_flush_cq(struct ocrdma_cq *cq) > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index bedc229be89d..1d25512416f5 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev, int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt, struct ib_udata *udata) { - int status = 0; struct ocrdma_cq *cq = get_ocrdma_cq(ibcq); - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) { - status = -EINVAL; - return status; - } + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) + return -EINVAL; ibcq->cqe = new_cnt; - return status; + return 0; } static void ocrdma_flush_cq(struct ocrdma_cq *cq)