| Message ID | 1491754328-28518-1-git-send-email-chunwang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/09/2017 12:12 PM, ChunYu Wang wrote: > Signed-off-by: ChunYu Wang <chunwang@redhat.com> > --- > Fix a potential memory leak issue caused by unfree pathname 'path'. > > systemd/nfs-server-generator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/systemd/nfs-server-generator.c b/systemd/nfs-server-generator.c > index 4aa6509..441cec5 100644 > --- a/systemd/nfs-server-generator.c > +++ b/systemd/nfs-server-generator.c > @@ -139,6 +139,7 @@ int main(int argc, char *argv[]) > strcat(path, filebase); > f = fopen(path, "w"); > if (!f) > + free(path); > exit(1); First of all you need some '{' '}' so the process will not always exit when f != NULL... Secondly dead process don't leak memory. :-) They don't leak anything... they are died! ;-) steved. > fprintf(f, "# Automatically generated by nfs-server-generator\n\n[Unit]\n"); > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
En, yes, Thanks for reviewing and reminding, it is my fault [ : ( ]. Valgrind did not notice me about the syntax rationality, but it's my duty. Get down to learn, and thanks a lot. Regards, ChunYu Wang On Mon, Apr 10, 2017 at 2:33 AM, Steve Dickson <SteveD@redhat.com> wrote: > > > On 04/09/2017 12:12 PM, ChunYu Wang wrote: >> Signed-off-by: ChunYu Wang <chunwang@redhat.com> >> --- >> Fix a potential memory leak issue caused by unfree pathname 'path'. >> >> systemd/nfs-server-generator.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/systemd/nfs-server-generator.c b/systemd/nfs-server-generator.c >> index 4aa6509..441cec5 100644 >> --- a/systemd/nfs-server-generator.c >> +++ b/systemd/nfs-server-generator.c >> @@ -139,6 +139,7 @@ int main(int argc, char *argv[]) >> strcat(path, filebase); >> f = fopen(path, "w"); >> if (!f) >> + free(path); >> exit(1); > First of all you need some '{' '}' so the process will not > always exit when f != NULL... > > Secondly dead process don't leak memory. :-) They don't leak anything... they are died! ;-) > > steved. > >> fprintf(f, "# Automatically generated by nfs-server-generator\n\n[Unit]\n"); >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/systemd/nfs-server-generator.c b/systemd/nfs-server-generator.c index 4aa6509..441cec5 100644 --- a/systemd/nfs-server-generator.c +++ b/systemd/nfs-server-generator.c @@ -139,6 +139,7 @@ int main(int argc, char *argv[]) strcat(path, filebase); f = fopen(path, "w"); if (!f) + free(path); exit(1); fprintf(f, "# Automatically generated by nfs-server-generator\n\n[Unit]\n");
Signed-off-by: ChunYu Wang <chunwang@redhat.com> --- Fix a potential memory leak issue caused by unfree pathname 'path'. systemd/nfs-server-generator.c | 1 + 1 file changed, 1 insertion(+)