| Message ID | 1491281188-6471-1-git-send-email-gbhat@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ecd7eb7c2bcf99f6c23d68ad56ce15949da848a1 |
| Delegated to: | Kalle Valo |
| Headers | show |
Ganapathi Bhat <gbhat@marvell.com> wrote: > We have to use start port, for TX/RX of single packet, > instead of current aggregating port. This will fix SDIO > CMD53(TX/RX) returning -ETIMEDOUT and halting the data path. > > fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet') > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com> The correct format is: Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet") I can fix that. (no pun intended)
> From: Kalle Valo [mailto:kvalo@codeaurora.org] > Sent: Wednesday, April 05, 2017 4:22 PM > To: Ganapathi Bhat > Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > Ganapathi Bhat > Subject: [EXT] Re: mwifiex: Fix invalid port issue > > Ganapathi Bhat <gbhat@marvell.com> wrote: > > We have to use start port, for TX/RX of single packet, instead of > > current aggregating port. This will fix SDIO > > CMD53(TX/RX) returning -ETIMEDOUT and halting the data path. > > > > fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx > single > > packet') > > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com> > > The correct format is: > > Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx > single packet") > > I can fix that. (no pun intended) Thanks Kalle. I will follow the same in future. > > -- > https://patchwork.kernel.org/patch/9660845/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submitting > patches Regards, Ganapathi
Ganapathi Bhat <gbhat@marvell.com> wrote: > We have to use start port, for TX/RX of single packet, > instead of current aggregating port. This will fix SDIO > CMD53(TX/RX) returning -ETIMEDOUT and halting the data path. > > Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet") > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com> Patch applied to wireless-drivers-next.git, thanks. ecd7eb7c2bcf mwifiex: Fix invalid port issue
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index 58d3da0..369450a 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -1380,7 +1380,7 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter, } if (card->mpa_rx.pkt_cnt == 1) - mport = adapter->ioport + port; + mport = adapter->ioport + card->mpa_rx.start_port; if (mwifiex_read_data_sync(adapter, card->mpa_rx.buf, card->mpa_rx.buf_len, mport, 1)) @@ -1813,7 +1813,7 @@ static int mwifiex_host_to_card_mp_aggr(struct mwifiex_adapter *adapter, } if (card->mpa_tx.pkt_cnt == 1) - mport = adapter->ioport + port; + mport = adapter->ioport + card->mpa_tx.start_port; ret = mwifiex_write_data_to_card(adapter, card->mpa_tx.buf, card->mpa_tx.buf_len, mport);
We have to use start port, for TX/RX of single packet, instead of current aggregating port. This will fix SDIO CMD53(TX/RX) returning -ETIMEDOUT and halting the data path. fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet') Signed-off-by: Ganapathi Bhat <gbhat@marvell.com> --- drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)