Message ID | 20170413160952.29918-1-mreitz@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, 04/13 18:09, Max Reitz wrote: > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 9c40b1f458..020b86b9f0 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap) > newmsg = g_string_new(NULL); > g_string_vprintf(newmsg, fmt, ap); > g_string_append(newmsg, (*errp)->msg); > + g_free((*errp)->msg); > (*errp)->msg = g_string_free(newmsg, 0); > } > > -- > 2.12.2 > > Reviewed-by: Fam Zheng <famz@redhat.com>
On Thu, Apr 13, 2017 at 06:09:52PM +0200, Max Reitz wrote: > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 9c40b1f458..020b86b9f0 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap) > newmsg = g_string_new(NULL); > g_string_vprintf(newmsg, fmt, ap); > g_string_append(newmsg, (*errp)->msg); > + g_free((*errp)->msg); > (*errp)->msg = g_string_free(newmsg, 0); > } > > -- > 2.12.2 > > Reviewed-by: Jeff Cody <jcody@redhat.com>
Max Reitz <mreitz@redhat.com> writes: > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > util/error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/error.c b/util/error.c > index 9c40b1f458..020b86b9f0 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap) > newmsg = g_string_new(NULL); > g_string_vprintf(newmsg, fmt, ap); > g_string_append(newmsg, (*errp)->msg); > + g_free((*errp)->msg); > (*errp)->msg = g_string_free(newmsg, 0); > } Applied to error-next, thanks!
diff --git a/util/error.c b/util/error.c index 9c40b1f458..020b86b9f0 100644 --- a/util/error.c +++ b/util/error.c @@ -134,6 +134,7 @@ void error_vprepend(Error **errp, const char *fmt, va_list ap) newmsg = g_string_new(NULL); g_string_vprintf(newmsg, fmt, ap); g_string_append(newmsg, (*errp)->msg); + g_free((*errp)->msg); (*errp)->msg = g_string_free(newmsg, 0); }
Signed-off-by: Max Reitz <mreitz@redhat.com> --- util/error.c | 1 + 1 file changed, 1 insertion(+)