| Message ID | 20170512112015.19082-1-arkadiusz.hiler@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes: > This basically reverts commit 465418c6064c > ("drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7") > with small addition - marking it as affecting KBL as well. s/KBL/GLK Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com> > > It was incorrectly considered fixed in production steppings. > > References: HSD#2126385, HSD#2131381, HSDES#1504433555, BSID#0764 > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Cc: Jeff McGee <jeff.mcgee@intel.com> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c > index 483ed76..49c2315 100644 > --- a/drivers/gpu/drm/i915/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c > @@ -851,8 +851,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine) > */ > } > > + /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk */ > /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */ > WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7, > + GEN9_ENABLE_YV12_BUGFIX | > GEN9_ENABLE_GPGPU_PREEMPTION); > > /* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk */ > -- > 2.9.3
Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes: > This basically reverts commit 465418c6064c > ("drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7") > with small addition - marking it as affecting KBL as well. > > It was incorrectly considered fixed in production steppings. > > References: HSD#2126385, HSD#2131381, HSDES#1504433555, BSID#0764 > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Cc: Jeff McGee <jeff.mcgee@intel.com> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> Pushed, thanks for the patch. -Mika > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c > index 483ed76..49c2315 100644 > --- a/drivers/gpu/drm/i915/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c > @@ -851,8 +851,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine) > */ > } > > + /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk */ > /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */ > WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7, > + GEN9_ENABLE_YV12_BUGFIX | > GEN9_ENABLE_GPGPU_PREEMPTION); > > /* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk */ > -- > 2.9.3
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c index 483ed76..49c2315 100644 --- a/drivers/gpu/drm/i915/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/intel_engine_cs.c @@ -851,8 +851,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine) */ } + /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk */ /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */ WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7, + GEN9_ENABLE_YV12_BUGFIX | GEN9_ENABLE_GPGPU_PREEMPTION); /* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk */
This basically reverts commit 465418c6064c ("drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7") with small addition - marking it as affecting KBL as well. It was incorrectly considered fixed in production steppings. References: HSD#2126385, HSD#2131381, HSDES#1504433555, BSID#0764 Cc: Mika Kuoppala <mika.kuoppala@intel.com> Cc: Jeff McGee <jeff.mcgee@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> --- drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++ 1 file changed, 2 insertions(+)