| Message ID | 20170516001150.11508-1-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16/05/2017 02:11, Philippe Mathieu-Daudé wrote: > spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > util/oslib-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/oslib-posix.c b/util/oslib-posix.c > index 4d9189e9ef..7ca02f0103 100644 > --- a/util/oslib-posix.c > +++ b/util/oslib-posix.c > @@ -447,7 +447,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus, > /* touch pages simultaneously */ > if (touch_all_pages(area, hpagesize, numpages, smp_cpus)) { > error_setg(errp, "os_mem_prealloc: Insufficient free host memory " > - "pages available to allocate guest RAM\n"); > + "pages available to allocate guest RAM"); > } > > ret = sigaction(SIGBUS, &oldact, NULL); > Reviewed-by: Laurent Vivier <lvivier@redhat.com>
On Mon, May 15, 2017 at 09:11:49PM -0300, Philippe Mathieu-Daudé wrote: > spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > util/oslib-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please send multi-patch series with a cover letter and proper patch numbering ([PATCH 0/2], [PATCH 1/2], [PATCH 2/2]). git-format-patch and git-send-email normally do this. It's important so that patch management tools and continuous integration systems can track your patches. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
On 05/17/2017 09:48 AM, Stefan Hajnoczi wrote: > On Mon, May 15, 2017 at 09:11:49PM -0300, Philippe Mathieu-Daudé wrote: >> spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> util/oslib-posix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Please send multi-patch series with a cover letter and proper patch > numbering ([PATCH 0/2], [PATCH 1/2], [PATCH 2/2]). git-format-patch and > git-send-email normally do this. It's important so that patch > management tools and continuous integration systems can track your > patches. Hi Stefan, I intended one command to generate unrelated patches from the same branch at once and send them individually without cover letter. I didn't noticed they'd go as a serie. I'll double-check next time! > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block Hmm I can't see it there maybe this part was not for this patch, I'll resend it soon with r-b tags. > > Stefan > Regards, Phil.
diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4d9189e9ef..7ca02f0103 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -447,7 +447,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory, int smp_cpus, /* touch pages simultaneously */ if (touch_all_pages(area, hpagesize, numpages, smp_cpus)) { error_setg(errp, "os_mem_prealloc: Insufficient free host memory " - "pages available to allocate guest RAM\n"); + "pages available to allocate guest RAM"); } ret = sigaction(SIGBUS, &oldact, NULL);
spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- util/oslib-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)