| Message ID | e3491aaa-f471-c67c-43dc-41d592159c8e@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 5/22/2017 7:11 AM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 22 May 2017 15:34:28 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > net/rds/ib.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/net/rds/ib.c b/net/rds/ib.c > index 7a64c8db81ab..c5514d058171 100644 > --- a/net/rds/ib.c > +++ b/net/rds/ib.c > @@ -166,8 +166,5 @@ static void rds_ib_add_one(struct ib_device *device) > - if (!rds_ibdev->vector_load) { > - pr_err("RDS/IB: %s failed to allocate vector memory\n", > - __func__); > + if (!rds_ibdev->vector_load) > goto put_dev; > - } > Well the ENOMEM is not carried here so the message was usefu but its not critical so its fine to clean that up. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/ib.c b/net/rds/ib.c index 7a64c8db81ab..c5514d058171 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -166,8 +166,5 @@ static void rds_ib_add_one(struct ib_device *device) - if (!rds_ibdev->vector_load) { - pr_err("RDS/IB: %s failed to allocate vector memory\n", - __func__); + if (!rds_ibdev->vector_load) goto put_dev; - } rds_ibdev->dev = device; rds_ibdev->pd = ib_alloc_pd(device, 0);