| Message ID | 20170525134503.12106-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4f8e25458cb6efc9e4497bb5cecb3a667d4963ab |
| Delegated to: | Kalle Valo |
| Headers | show |
> mac is being assigned twice, remove redundant 2nd assignment. > > Detected by CoverityScan, CID#1437554 ("Incorrect expression") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > index fc0ce2c09097..e3c090008125 100644 > --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c > @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up) > void qtnf_virtual_intf_cleanup(struct net_device *ndev) > { > struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev); > - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy); > + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy); Thanks ! Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Colin Ian King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > mac is being assigned twice, remove redundant 2nd assignment. > > Detected by CoverityScan, CID#1437554 ("Incorrect expression") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> Patch applied to wireless-drivers-next.git, thanks. 4f8e25458cb6 qtnfmac: remove duplicated assignment to mac
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c index fc0ce2c09097..e3c090008125 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c +++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c @@ -922,7 +922,7 @@ void qtnf_netdev_updown(struct net_device *ndev, bool up) void qtnf_virtual_intf_cleanup(struct net_device *ndev) { struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev); - struct qtnf_wmac *mac = mac = wiphy_priv(vif->wdev.wiphy); + struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy); if (vif->wdev.iftype == NL80211_IFTYPE_STATION) { switch (vif->sta_state) {