Message ID | 20170719092415.9553-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Herbert Xu |
Headers | show |
On 07/19/2017 12:24 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are > local to the source and no not need to be in the global scope. Make > them static. > > Cleans up sparse warnings: > symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static? > symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Tudor Ambarus <tudor.ambarus@microchip.com> Thanks, ta
On Wed, Jul 19, 2017 at 10:24:15AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Functions atmel_ecc_i2c_client_alloc and atmel_ecc_i2c_client_free are > local to the source and no not need to be in the global scope. Make > them static. > > Cleans up sparse warnings: > symbol 'atmel_ecc_i2c_client_alloc' was not declared. Should it be static? > symbol 'atmel_ecc_i2c_client_free' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied. Thanks.
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 66ab1021eba5..c6e8de2b28dd 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -492,7 +492,7 @@ static int atmel_ecdh_compute_shared_secret(struct kpp_request *req) return ret; } -struct i2c_client *atmel_ecc_i2c_client_alloc(void) +static struct i2c_client *atmel_ecc_i2c_client_alloc(void) { struct atmel_ecc_i2c_client_priv *i2c_priv, *min_i2c_priv = NULL; struct i2c_client *client = ERR_PTR(-ENODEV); @@ -527,7 +527,7 @@ struct i2c_client *atmel_ecc_i2c_client_alloc(void) return client; } -void atmel_ecc_i2c_client_free(struct i2c_client *client) +static void atmel_ecc_i2c_client_free(struct i2c_client *client) { struct atmel_ecc_i2c_client_priv *i2c_priv = i2c_get_clientdata(client);