| Message ID | 1500600366-181656-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On 2017/7/21 9:26, Shawn Lin wrote: > It was never used and also introduce a warning > > drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe': > drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but > not used [-Wunused-but-set-variable] > > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Acked-by: Zhou Wang <wangzhou1@hisilicon.com> Thanks, Zhou > --- > > drivers/pci/dwc/pcie-hisi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c > index e51acee..6631654 100644 > --- a/drivers/pci/dwc/pcie-hisi.c > +++ b/drivers/pci/dwc/pcie-hisi.c > @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) > struct dw_pcie *pci; > struct hisi_pcie *hisi_pcie; > struct resource *reg; > - struct device_driver *driver; > int ret; > > hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL); > @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) > pci->dev = dev; > pci->ops = &dw_pcie_ops; > > - driver = dev->driver; > - > hisi_pcie->pci = pci; > > hisi_pcie->soc_ops = of_device_get_match_data(dev); >
> -----Original Message----- > From: Shawn Lin [mailto:shawn.lin@rock-chips.com] > Sent: 21 July 2017 09:26 > To: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org; Shawn Lin; Gabriele Paoloni; Wangzhou (B) > Subject: [PATCH] PCI: hisi: remove unused variable driver > > It was never used and also introduce a warning > > drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe': > drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but > not used [-Wunused-but-set-variable] > > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Acked-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> Thanks Gab [...]
On Fri, Jul 21, 2017 at 09:26:06AM +0800, Shawn Lin wrote: > It was never used and also introduce a warning > > drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe': > drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but > not used [-Wunused-but-set-variable] > > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Applied to pci/host-hisi for v4.14 with acks from Zhou and Gabriele, thanks! > --- > > drivers/pci/dwc/pcie-hisi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c > index e51acee..6631654 100644 > --- a/drivers/pci/dwc/pcie-hisi.c > +++ b/drivers/pci/dwc/pcie-hisi.c > @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) > struct dw_pcie *pci; > struct hisi_pcie *hisi_pcie; > struct resource *reg; > - struct device_driver *driver; > int ret; > > hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL); > @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) > pci->dev = dev; > pci->ops = &dw_pcie_ops; > > - driver = dev->driver; > - > hisi_pcie->pci = pci; > > hisi_pcie->soc_ops = of_device_get_match_data(dev); > -- > 1.9.1 > >
diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c index e51acee..6631654 100644 --- a/drivers/pci/dwc/pcie-hisi.c +++ b/drivers/pci/dwc/pcie-hisi.c @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) struct dw_pcie *pci; struct hisi_pcie *hisi_pcie; struct resource *reg; - struct device_driver *driver; int ret; hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL); @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev) pci->dev = dev; pci->ops = &dw_pcie_ops; - driver = dev->driver; - hisi_pcie->pci = pci; hisi_pcie->soc_ops = of_device_get_match_data(dev);
It was never used and also introduce a warning drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe': drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but not used [-Wunused-but-set-variable] Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> Cc: Zhou Wang <wangzhou1@hisilicon.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- drivers/pci/dwc/pcie-hisi.c | 3 --- 1 file changed, 3 deletions(-)