| Message ID | 20170607204202.GA29640@embeddedgus (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jun 07, 2017 at 03:42:02PM -0500, Gustavo A. R. Silva wrote: > Remove duplicate code. > > Addresses-Coverity-ID: 1226951 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/infiniband/hw/qib/qib_mad.c | 2 -- > 1 file changed, 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: > Remove duplicate code. > > Addresses-Coverity-ID: 1226951 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/infiniband/hw/qib/qib_mad.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c > index da295e0..c5eaa3c 100644 > --- a/drivers/infiniband/hw/qib/qib_mad.c > +++ b/drivers/infiniband/hw/qib/qib_mad.c > @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev, > ib_dispatch_event(&event); > } > > - ret = subn_get_portinfo(smp, ibdev, port); > - > /* restore re-reg bit per o14-12.2.1 */ > pip->clientrereg_resv_subnetto |= clientrereg; > > Would be nice to see a few more words in the commit message rather than having to go look for Coverity. Regardless, patch seems fine to me code wise. Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dennis, Quoting Dennis Dalessandro <dennis.dalessandro@intel.com>: > On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: >> Remove duplicate code. >> >> Addresses-Coverity-ID: 1226951 >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> drivers/infiniband/hw/qib/qib_mad.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/infiniband/hw/qib/qib_mad.c >> b/drivers/infiniband/hw/qib/qib_mad.c >> index da295e0..c5eaa3c 100644 >> --- a/drivers/infiniband/hw/qib/qib_mad.c >> +++ b/drivers/infiniband/hw/qib/qib_mad.c >> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp >> *smp, struct ib_device *ibdev, >> ib_dispatch_event(&event); >> } >> - ret = subn_get_portinfo(smp, ibdev, port); >> - >> /* restore re-reg bit per o14-12.2.1 */ >> pip->clientrereg_resv_subnetto |= clientrereg; >> > > Would be nice to see a few more words in the commit message rather > than having to go look for Coverity. > I'll take note of that. > Regardless, patch seems fine to me code wise. > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Thank you -- Gustavo A. R. Silva -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: > Remove duplicate code. > > Addresses-Coverity-ID: 1226951 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> This patch was accepted into 4.13-rc, thanks. In addition, I no longer have the original email for another patch of yours that was also accepted into 4.13-rc. You created the patch in a thread asking about the argument position for argument usage in ib_init_ah_from_wc(). Your comment addition was accepted as well.
On 7/22/2017 1:20 PM, Doug Ledford wrote: > On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: >> Remove duplicate code. >> >> Addresses-Coverity-ID: 1226951 >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > > This patch was accepted into 4.13-rc, thanks. Correction, this patch is in my queue for my for-next branch, only the other patch, referenced below, made it into 4.13-rc. > In addition, I no longer have the original email for another patch of > yours that was also accepted into 4.13-rc. You created the patch in a > thread asking about the argument position for argument usage in > ib_init_ah_from_wc(). Your comment addition was accepted as well. > >
Hi Doug, On 07/22/2017 12:22 PM, Doug Ledford wrote: > On 7/22/2017 1:20 PM, Doug Ledford wrote: >> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote: >>> Remove duplicate code. >>> >>> Addresses-Coverity-ID: 1226951 >>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> >> This patch was accepted into 4.13-rc, thanks. > > Correction, this patch is in my queue for my for-next branch, only the > other patch, referenced below, made it into 4.13-rc. > That's cool. >> In addition, I no longer have the original email for another patch of >> yours that was also accepted into 4.13-rc. You created the patch in a >> thread asking about the argument position for argument usage in >> ib_init_ah_from_wc(). Your comment addition was accepted as well. >> >> Yeah, I noticed that. I'm glad to help out. :) Thank you
diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c index da295e0..c5eaa3c 100644 --- a/drivers/infiniband/hw/qib/qib_mad.c +++ b/drivers/infiniband/hw/qib/qib_mad.c @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev, ib_dispatch_event(&event); } - ret = subn_get_portinfo(smp, ibdev, port); - /* restore re-reg bit per o14-12.2.1 */ pip->clientrereg_resv_subnetto |= clientrereg;
Remove duplicate code. Addresses-Coverity-ID: 1226951 Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/infiniband/hw/qib/qib_mad.c | 2 -- 1 file changed, 2 deletions(-)