| Message ID | 1500371102-14758-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e66d70b789d1db8e152d79dd070459ae9e566acc |
| Delegated to: | Kalle Valo |
| Headers | show |
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by <linux/sysfs.h> work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> 4 patches applied to wireless-drivers-next.git, thanks. 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient" 185ffc194800 ipw2100: don't return positive values to PCI probe on error af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate' e66d70b789d1 brcmfmac: constify pci_device_id
Kalle Valo <kvalo@codeaurora.org> writes: > Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by <linux/sysfs.h> work >> with const attribute_group. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > 4 patches applied to wireless-drivers-next.git, thanks. > > 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient" > 185ffc194800 ipw2100: don't return positive values to PCI probe on error > af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate' > e66d70b789d1 brcmfmac: constify pci_device_id Please ignore this mail, I have a bug in my patchwork script.
Kalle Valo <kvalo@codeaurora.org> writes: > Kalle Valo <kvalo@codeaurora.org> writes: > >> Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: >> >>> attribute_group are not supposed to change at runtime. All functions >>> working with attribute_group provided by <linux/sysfs.h> work >>> with const attribute_group. So mark the non-const structs as const. >>> >>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> >> 4 patches applied to wireless-drivers-next.git, thanks. >> >> 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient" >> 185ffc194800 ipw2100: don't return positive values to PCI probe on error >> af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate' >> e66d70b789d1 brcmfmac: constify pci_device_id > > Please ignore this mail, I have a bug in my patchwork script. The reason was that Dave had already applied these patches but my script failed to detect that. I need to fix my script.
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 9368abd..c311b1a 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -11500,7 +11500,7 @@ static int ipw_wdev_init(struct net_device *dev) NULL }; -static struct attribute_group ipw_attribute_group = { +static const struct attribute_group ipw_attribute_group = { .name = NULL, /* put in device directory */ .attrs = ipw_sysfs_entries, };
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- Changes in v2: Added cover later. Changes in v3: net-next was closed. Now resubmitting it. drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)