| Message ID | 1502208353-12447-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 08/08/2017 11:05 AM, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by <linux/usb.h> work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Thanks, Larry > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > index 96c923b..e673bc2 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = { > #define USB_VENDER_ID_REALTEK 0x0bda > > /* 2010-10-19 DID_USB_V3.4 */ > -static struct usb_device_id rtl8192c_usb_ids[] = { > +static const struct usb_device_id rtl8192c_usb_ids[] = { > > /*=== Realtek demoboard ===*/ > /* Default ID */ >
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c index 96c923b..e673bc2 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = { #define USB_VENDER_ID_REALTEK 0x0bda /* 2010-10-19 DID_USB_V3.4 */ -static struct usb_device_id rtl8192c_usb_ids[] = { +static const struct usb_device_id rtl8192c_usb_ids[] = { /*=== Realtek demoboard ===*/ /* Default ID */
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by <linux/usb.h> work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)