diff mbox

[rdma-core] vmw_pvrdma: Add L2 MAC resolution for UD QPs

Message ID 1502345099-6534-1-git-send-email-aditr@vmware.com (mailing list archive)
State Accepted
Headers show

Commit Message

Adit Ranadive Aug. 10, 2017, 6:04 a.m. UTC 
From: Bryan Tan <bryantan@vmware.com>

From: Bryan Tan <bryantan@vmware.com>

Use a libibverbs function to resolve the destination MAC address
for a non-default GID in UD QPs.

Signed-off-by: Bryan Tan <bryantan@vmware.com>
Signed-off-by: Adit Ranadive <aditr@vmware.com>
---
 providers/vmw_pvrdma/verbs.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Leon Romanovsky Aug. 10, 2017, 6:18 a.m. UTC | #1 
On Wed, Aug 09, 2017 at 11:04:59PM -0700, Adit Ranadive wrote:
> From: Bryan Tan <bryantan@vmware.com>
>
> From: Bryan Tan <bryantan@vmware.com>
>
> Use a libibverbs function to resolve the destination MAC address
> for a non-default GID in UD QPs.
>
> Signed-off-by: Bryan Tan <bryantan@vmware.com>
> Signed-off-by: Adit Ranadive <aditr@vmware.com>
> ---
>  providers/vmw_pvrdma/verbs.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>

Thanks, applied.
Yuval Shaia Aug. 10, 2017, 11:26 a.m. UTC | #2 
On Wed, Aug 09, 2017 at 11:04:59PM -0700, Adit Ranadive wrote:
> From: Bryan Tan <bryantan@vmware.com>
> 
> From: Bryan Tan <bryantan@vmware.com>
> 
> Use a libibverbs function to resolve the destination MAC address

s/libibverbs/ibverbs

> for a non-default GID in UD QPs.
> 
> Signed-off-by: Bryan Tan <bryantan@vmware.com>
> Signed-off-by: Adit Ranadive <aditr@vmware.com>
> ---
>  providers/vmw_pvrdma/verbs.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/providers/vmw_pvrdma/verbs.c b/providers/vmw_pvrdma/verbs.c
> index 1bb1634..852aced 100644
> --- a/providers/vmw_pvrdma/verbs.c
> +++ b/providers/vmw_pvrdma/verbs.c
> @@ -186,6 +186,7 @@ struct ibv_ah *pvrdma_create_ah(struct ibv_pd *pd,
>  	struct pvrdma_ah *ah;
>  	struct pvrdma_av *av;
>  	struct ibv_port_attr port_attr;
> +	uint16_t vlan_id;
>  
>  	if (!attr->is_global)
>  		return NULL;
> @@ -216,7 +217,14 @@ struct ibv_ah *pvrdma_create_ah(struct ibv_pd *pd,
>  	av->sl_tclass_flowlabel = (attr->grh.traffic_class << 20) |
>  				   attr->grh.flow_label;
>  	memcpy(av->dgid, attr->grh.dgid.raw, 16);
> -	set_mac_from_gid(&attr->grh.dgid, av->dmac);
> +
> +	if (ibv_resolve_eth_l2_from_gid(pd->context, attr,
> +					av->dmac, &vlan_id)) {
> +		free(ah);
> +		return NULL;
> +	} else {
> +		set_mac_from_gid(&attr->grh.dgid, av->dmac);
> +	}
>  
>  	return &ah->ibv_ah;
>  }
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/providers/vmw_pvrdma/verbs.c b/providers/vmw_pvrdma/verbs.c
index 1bb1634..852aced 100644
--- a/providers/vmw_pvrdma/verbs.c
+++ b/providers/vmw_pvrdma/verbs.c
@@ -186,6 +186,7 @@  struct ibv_ah *pvrdma_create_ah(struct ibv_pd *pd,
 	struct pvrdma_ah *ah;
 	struct pvrdma_av *av;
 	struct ibv_port_attr port_attr;
+	uint16_t vlan_id;
 
 	if (!attr->is_global)
 		return NULL;
@@ -216,7 +217,14 @@  struct ibv_ah *pvrdma_create_ah(struct ibv_pd *pd,
 	av->sl_tclass_flowlabel = (attr->grh.traffic_class << 20) |
 				   attr->grh.flow_label;
 	memcpy(av->dgid, attr->grh.dgid.raw, 16);
-	set_mac_from_gid(&attr->grh.dgid, av->dmac);
+
+	if (ibv_resolve_eth_l2_from_gid(pd->context, attr,
+					av->dmac, &vlan_id)) {
+		free(ah);
+		return NULL;
+	} else {
+		set_mac_from_gid(&attr->grh.dgid, av->dmac);
+	}
 
 	return &ah->ibv_ah;
 }