diff mbox

IB/mlx5: make function mlx5_ib_get_vector_affinity

Message ID 20170816092940.11158-1-colin.king@canonical.com (mailing list archive)
State Superseded
Headers show

Commit Message

Colin King Aug. 16, 2017, 9:29 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The function mlx5_ib_get_vector_affinity is local to the source
and does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'mlx5_ib_get_vector_affinity' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/mlx5/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Leon Romanovsky Aug. 16, 2017, 10:03 a.m. UTC | #1
On Wed, Aug 16, 2017 at 10:29:40AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function mlx5_ib_get_vector_affinity is local to the source
> and does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'mlx5_ib_get_vector_affinity' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Hi Colin,

It was already posted to the mailing list:
https://patchwork.kernel.org/patch/9901353/

Thanks
diff mbox

Patch

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index cde7d1ce4a3c..a9e684deb6a4 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -3816,8 +3816,8 @@  static void init_delay_drop(struct mlx5_ib_dev *dev)
 		mlx5_ib_warn(dev, "Failed to init delay drop debugfs\n");
 }
 
-const struct cpumask *mlx5_ib_get_vector_affinity(struct ib_device *ibdev,
-		int comp_vector)
+static const struct cpumask *mlx5_ib_get_vector_affinity(
+	struct ib_device *ibdev, int comp_vector)
 {
 	struct mlx5_ib_dev *dev = to_mdev(ibdev);