| Message ID | 20170728105112.7577-1-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote: > This file uses interrupt APIs but doesn't explicitly include > linux/interrupt.h meaning that changes in other header files could > cause > build breakage as happened in next-20170728 for arm64. Add an > explicit > include to avoid such problems. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c > b/drivers/infiniband/hw/hns/hns_roce_eq.c > index 50f864935a0e..e1e4c16ca3d5 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_eq.c > +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c > @@ -30,6 +30,7 @@ > * SOFTWARE. > */ > > +#include <linux/interrupt.h> > #include <linux/platform_device.h> > #include "hns_roce_common.h" > #include "hns_roce_device.h" Hi Mark, Your patch is fine, but I grabbed the one from Arnd before I grabbed this one. That was an accident on my part (yours was sent to the list first and I normally would have grabbed it), my apologies for that. I knew I had seen a patch come through and I scrolled back until I found it without realizing there were two.
Hi, Doug & Mark Brown & Arnd Bergmann Thanks for your patches! @Doug, Which branch can we found this patch? Thanks Regards Wei Hu On 2017/8/1 3:24, Doug Ledford wrote: > On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote: >> This file uses interrupt APIs but doesn't explicitly include >> linux/interrupt.h meaning that changes in other header files could >> cause >> build breakage as happened in next-20170728 for arm64. Add an >> explicit >> include to avoid such problems. >> >> Signed-off-by: Mark Brown <broonie@kernel.org> >> --- >> drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c >> b/drivers/infiniband/hw/hns/hns_roce_eq.c >> index 50f864935a0e..e1e4c16ca3d5 100644 >> --- a/drivers/infiniband/hw/hns/hns_roce_eq.c >> +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c >> @@ -30,6 +30,7 @@ >> * SOFTWARE. >> */ >> >> +#include <linux/interrupt.h> >> #include <linux/platform_device.h> >> #include "hns_roce_common.h" >> #include "hns_roce_device.h" > Hi Mark, > > Your patch is fine, but I grabbed the one from Arnd before I grabbed > this one. That was an accident on my part (yours was sent to the list > first and I normally would have grabbed it), my apologies for that. I > knew I had seen a patch come through and I scrolled back until I found > it without realizing there were two. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2017-08-22 at 10:21 +0800, Wei Hu (Xavier) wrote: > Hi, Doug & Mark Brown & Arnd Bergmann > Thanks for your patches! > > @Doug, Which branch can we found this patch? Thanks I put this in -rc, it should already be visible to you in Linus' master branch. > Regards > Wei Hu > > On 2017/8/1 3:24, Doug Ledford wrote: > > On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote: > > > This file uses interrupt APIs but doesn't explicitly include > > > linux/interrupt.h meaning that changes in other header files > > > could > > > cause > > > build breakage as happened in next-20170728 for arm64. Add an > > > explicit > > > include to avoid such problems. > > > > > > Signed-off-by: Mark Brown <broonie@kernel.org> > > > --- > > > drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c > > > b/drivers/infiniband/hw/hns/hns_roce_eq.c > > > index 50f864935a0e..e1e4c16ca3d5 100644 > > > --- a/drivers/infiniband/hw/hns/hns_roce_eq.c > > > +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c > > > @@ -30,6 +30,7 @@ > > > * SOFTWARE. > > > */ > > > > > > +#include <linux/interrupt.h> > > > #include <linux/platform_device.h> > > > #include "hns_roce_common.h" > > > #include "hns_roce_device.h" > > > > Hi Mark, > > > > Your patch is fine, but I grabbed the one from Arnd before I > > grabbed > > this one. That was an accident on my part (yours was sent to the > > list > > first and I normally would have grabbed it), my apologies for > > that. I > > knew I had seen a patch come through and I scrolled back until I > > found > > it without realizing there were two. > > > >
diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c index 50f864935a0e..e1e4c16ca3d5 100644 --- a/drivers/infiniband/hw/hns/hns_roce_eq.c +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c @@ -30,6 +30,7 @@ * SOFTWARE. */ +#include <linux/interrupt.h> #include <linux/platform_device.h> #include "hns_roce_common.h" #include "hns_roce_device.h"
This file uses interrupt APIs but doesn't explicitly include linux/interrupt.h meaning that changes in other header files could cause build breakage as happened in next-20170728 for arm64. Add an explicit include to avoid such problems. Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + 1 file changed, 1 insertion(+)