| Message ID | 20170830134223.GA13596@embeddedgus (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226788 > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > This issue was reported by Coverity and it was tested by compilation only. > I'm suspicious this may be a copy/paste error. Please, verify. I have referred this change to the engineers at Realtek. For the moment, please hold this patch. Thanks for reporting the condition. Larry
Hi Larry, On 08/30/2017 11:37 AM, Larry Finger wrote: > On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: >> Refactor code in order to avoid identical code for different branches. >> >> This issue was detected with the help of Coccinelle. >> >> Addresses-Coverity-ID: 1226788 >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> This issue was reported by Coverity and it was tested by compilation >> only. >> I'm suspicious this may be a copy/paste error. Please, verify. > > I have referred this change to the engineers at Realtek. For the moment, > please hold this patch. > > Thanks for reporting the condition. > Glad to help. :)
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226788 > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > This issue was reported by Coverity and it was tested by compilation only. > I'm suspicious this may be a copy/paste error. Please, verify. > > .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This change is not correct. When bt_link_info->sco_exist is true, the call should be halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC, true, false, 0x5); NACK I will push the correct patch. Larry
Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: > On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: >> Refactor code in order to avoid identical code for different branches. >> >> This issue was detected with the help of Coccinelle. >> >> Addresses-Coverity-ID: 1226788 >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> This issue was reported by Coverity and it was tested by compilation >> only. >> I'm suspicious this may be a copy/paste error. Please, verify. >> >> .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 >> ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) > > This change is not correct. When bt_link_info->sco_exist is true, the > call should be > > halbtc8723b1ant_limited_rx(btcoexist, > NORMAL_EXEC, true, > false, 0x5); > > NACK > > I will push the correct patch. > Great. Good to know. Thanks
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c index c044252..960ce80f 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c @@ -2260,14 +2260,8 @@ static void halbtc8723b1ant_run_coexist_mechanism(struct btc_coexist *btcoexist) if (iot_peer != BTC_IOT_PEER_CISCO && iot_peer != BTC_IOT_PEER_BROADCOM) { - if (bt_link_info->sco_exist) - halbtc8723b1ant_limited_rx(btcoexist, - NORMAL_EXEC, false, - false, 0x5); - else - halbtc8723b1ant_limited_rx(btcoexist, - NORMAL_EXEC, false, - false, 0x5); + halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC, + false, false, 0x5); } else { if (bt_link_info->sco_exist) { halbtc8723b1ant_limited_rx(btcoexist,
Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226788 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- This issue was reported by Coverity and it was tested by compilation only. I'm suspicious this may be a copy/paste error. Please, verify. .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)