| Message ID | 20170913172620.24829-1-jarkko.sakkinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote: > The local variable 'attrs' should have the type __be32 instead of u32. > > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands") > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> All 3 look good to me: Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 13, 2017 at 12:14:21PM -0600, Jason Gunthorpe wrote: > On Wed, Sep 13, 2017 at 10:26:20AM -0700, Jarkko Sakkinen wrote: > > The local variable 'attrs' should have the type __be32 instead of u32. > > > > Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands") > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > All 3 look good to me: > > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > Jason Thanks! /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c index 70ee32816c48..f40d20671a78 100644 --- a/drivers/char/tpm/tpm2-cmd.c +++ b/drivers/char/tpm/tpm2-cmd.c @@ -980,7 +980,7 @@ static int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip) { struct tpm_buf buf; u32 nr_commands; - u32 *attrs; + __be32 *attrs; u32 cc; int i; int rc; @@ -1020,7 +1020,7 @@ static int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip) chip->nr_commands = nr_commands; - attrs = (u32 *)&buf.data[TPM_HEADER_SIZE + 9]; + attrs = (__be32 *)&buf.data[TPM_HEADER_SIZE + 9]; for (i = 0; i < nr_commands; i++, attrs++) { chip->cc_attrs_tbl[i] = be32_to_cpup(attrs); cc = chip->cc_attrs_tbl[i] & 0xFFFF;
The local variable 'attrs' should have the type __be32 instead of u32. Fixes: 58472f5cd4f6 ("tpm: validate TPM 2.0 commands") Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> --- drivers/char/tpm/tpm2-cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)