| Message ID | 20170902014451.17766-2-igor.mitsyanko.os@quantenna.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
For the whole patch set:
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> wrote: > From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> > > Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> > Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> No empty commit logs, please. After the first patch I was about to write one myself but after seeing multiple of them I'm not going to do that. 9 patches set to Changes Requested. 9935431 [V2,1/9] qtnfmac: qlink: convert channel width from bitfiled to simple enum 9935437 [V2,2/9] qtnfmac: make "Channel change" event report full channel info 9935443 [V2,3/9] qtnfmac: retrieve current channel info from EP 9935445 [V2,4/9] qtnfmac: do not cache channel info from "connect" command 9935429 [V2,5/9] qtnfmac: let wifi card handle channel switch request to the same chan 9935441 [V2,6/9] qtnfmac: pass VIF info to SendChannel command 9935433 [V2,7/9] qtnfmac: do not cache CSA chandef info 9935439 [V2,8/9] qtnfmac: remove unused mac::status field 9935435 [V2,9/9] qtnfmac: do not report channel changes until wiphy is registered
Kalle Valo <kvalo@codeaurora.org> writes: > Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> wrote: > >> From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> >> >> Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> >> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> > > No empty commit logs, please. After the first patch I was about to write > one myself but after seeing multiple of them I'm not going to do that. > > 9 patches set to Changes Requested. BTW, I got a mail undelivered message. Not sure why smtp.codeaurora.org could not find the host but reporting it here just in case: <avinashp@quantenna.com>: unable to look up host quantenna-com.mail.protection.outlook.com: Name or service not known <igor.mitsyanko.os@quantenna.com>: unable to look up host quantenna-com.mail.protection.outlook.com: Name or service not known <sergey.matyukevich.os@quantenna.com>: unable to look up host quantenna-com.mail.protection.outlook.com: Name or service not known
Hello Kalle, > BTW, I got a mail undelivered message. Not sure why smtp.codeaurora.org > could not find the host but reporting it here just in case: > > <avinashp@quantenna.com>: unable to look up host > quantenna-com.mail.protection.outlook.com: Name or service not known > > <igor.mitsyanko.os@quantenna.com>: unable to look up host > quantenna-com.mail.protection.outlook.com: Name or service not known > > <sergey.matyukevich.os@quantenna.com>: unable to look up host > quantenna-com.mail.protection.outlook.com: Name or service not known Thanks for letting us know. I see those emails im my box, but probably because of mailing list subscription. I will check with colleagues if they see your replies as well. Regards, Sergey
diff --git a/drivers/net/wireless/quantenna/qtnfmac/qlink.h b/drivers/net/wireless/quantenna/qtnfmac/qlink.h index a8242f6..a69fd470 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/qlink.h +++ b/drivers/net/wireless/quantenna/qtnfmac/qlink.h @@ -108,14 +108,14 @@ enum qlink_sta_flags { }; enum qlink_channel_width { - QLINK_CHAN_WIDTH_5 = BIT(0), - QLINK_CHAN_WIDTH_10 = BIT(1), - QLINK_CHAN_WIDTH_20_NOHT = BIT(2), - QLINK_CHAN_WIDTH_20 = BIT(3), - QLINK_CHAN_WIDTH_40 = BIT(4), - QLINK_CHAN_WIDTH_80 = BIT(5), - QLINK_CHAN_WIDTH_80P80 = BIT(6), - QLINK_CHAN_WIDTH_160 = BIT(7), + QLINK_CHAN_WIDTH_5 = 0, + QLINK_CHAN_WIDTH_10, + QLINK_CHAN_WIDTH_20_NOHT, + QLINK_CHAN_WIDTH_20, + QLINK_CHAN_WIDTH_40, + QLINK_CHAN_WIDTH_80, + QLINK_CHAN_WIDTH_80P80, + QLINK_CHAN_WIDTH_160, }; /* QLINK Command messages related definitions diff --git a/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c b/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c index cf024c9..369b77d 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c +++ b/drivers/net/wireless/quantenna/qtnfmac/qlink_util.c @@ -49,28 +49,28 @@ u8 qlink_chan_width_mask_to_nl(u16 qlink_mask) { u8 result = 0; - if (qlink_mask & QLINK_CHAN_WIDTH_5) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_5)) result |= BIT(NL80211_CHAN_WIDTH_5); - if (qlink_mask & QLINK_CHAN_WIDTH_10) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_10)) result |= BIT(NL80211_CHAN_WIDTH_10); - if (qlink_mask & QLINK_CHAN_WIDTH_20_NOHT) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_20_NOHT)) result |= BIT(NL80211_CHAN_WIDTH_20_NOHT); - if (qlink_mask & QLINK_CHAN_WIDTH_20) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_20)) result |= BIT(NL80211_CHAN_WIDTH_20); - if (qlink_mask & QLINK_CHAN_WIDTH_40) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_40)) result |= BIT(NL80211_CHAN_WIDTH_40); - if (qlink_mask & QLINK_CHAN_WIDTH_80) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_80)) result |= BIT(NL80211_CHAN_WIDTH_80); - if (qlink_mask & QLINK_CHAN_WIDTH_80P80) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_80P80)) result |= BIT(NL80211_CHAN_WIDTH_80P80); - if (qlink_mask & QLINK_CHAN_WIDTH_160) + if (qlink_mask & BIT(QLINK_CHAN_WIDTH_160)) result |= BIT(NL80211_CHAN_WIDTH_160); return result;