| Message ID | 1507078237-32366-1-git-send-email-avinash.repaka@oracle.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Avinash, On 10/3/2017 5:50 PM, Avinash Repaka wrote: > Use max_1m_mrs/max_8k_mrs while setting max_items, as the former > variables are set based on the underlying device attricutes. > s/attricutes/attributes > Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com> > --- > net/rds/ib_rdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This patch is fine but it will be nice if you can collect these changes in series as you are trying to update the FRWR support. Like this patch and other cleanup patch you posted yesterday. With that log fixed, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c index 9a3c54e..e678699 100644 --- a/net/rds/ib_rdma.c +++ b/net/rds/ib_rdma.c @@ -601,11 +601,11 @@ struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_ibdev, if (pool_type == RDS_IB_MR_1M_POOL) { /* +1 allows for unaligned MRs */ pool->fmr_attr.max_pages = RDS_MR_1M_MSG_SIZE + 1; - pool->max_items = RDS_MR_1M_POOL_SIZE; + pool->max_items = rds_ibdev->max_1m_mrs; } else { /* pool_type == RDS_IB_MR_8K_POOL */ pool->fmr_attr.max_pages = RDS_MR_8K_MSG_SIZE + 1; - pool->max_items = RDS_MR_8K_POOL_SIZE; + pool->max_items = rds_ibdev->max_8k_mrs; } pool->max_free_pinned = pool->max_items * pool->fmr_attr.max_pages / 4;
Use max_1m_mrs/max_8k_mrs while setting max_items, as the former variables are set based on the underlying device attricutes. Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com> --- net/rds/ib_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)