diff mbox

PCI: turn off PCIe services during shutdown

Message ID 1508958063-6947-1-git-send-email-okaya@codeaurora.org (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Sinan Kaya Oct. 25, 2017, 7:01 p.m. UTC
Some of the PCIe services such as AER are being left enabled during
shutdown. This might cause spurious AER errors while SOC is being
powered down.

Let's clean up the PCIe services gracefully during shutdown to clear
these false positives.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/pci/pcie/portdrv_pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Helgaas Nov. 7, 2017, 12:11 a.m. UTC | #1
On Wed, Oct 25, 2017 at 03:01:02PM -0400, Sinan Kaya wrote:
> Some of the PCIe services such as AER are being left enabled during
> shutdown. This might cause spurious AER errors while SOC is being
> powered down.
> 
> Let's clean up the PCIe services gracefully during shutdown to clear
> these false positives.
> 
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>

Applied to pci/portdrv for v4.15, thanks!

> ---
>  drivers/pci/pcie/portdrv_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 083276e..b350d12 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -246,6 +246,7 @@ static void pcie_portdrv_err_resume(struct pci_dev *dev)
>  
>  	.probe		= pcie_portdrv_probe,
>  	.remove		= pcie_portdrv_remove,
> +	.shutdown	= pcie_portdrv_remove,
>  
>  	.err_handler	= &pcie_portdrv_err_handler,
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index 083276e..b350d12 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -246,6 +246,7 @@  static void pcie_portdrv_err_resume(struct pci_dev *dev)
 
 	.probe		= pcie_portdrv_probe,
 	.remove		= pcie_portdrv_remove,
+	.shutdown	= pcie_portdrv_remove,
 
 	.err_handler	= &pcie_portdrv_err_handler,