| Message ID | 20171109150528.GA7629@bhelgaas-glaptop.roam.corp.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Hi Bjorn, On 2017/11/9 23:05, Bjorn Helgaas wrote: > On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: >> Hi Bjorn, >> >> On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: >>> On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: >>>> From: Bjorn Helgaas <bhelgaas@google.com> >>>> >>>> Add Lorenzo Pieralisi as maintainer for PCI native host bridge drivers and >>>> the endpoint driver framework. >>>> >>>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >>> >>> This is on my for-linus branch, and I intend to merge it for v4.14. >> >> There is already an entry for PCI endpoint in MAINTAINERS file. Can Lorenzo be >> added there? >> >> PCI ENDPOINT SUBSYSTEM >> M: Kishon Vijay Abraham I <kishon@ti.com> >> L: linux-pci@vger.kernel.org >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git >> S: Supported >> F: drivers/pci/endpoint/ >> F: drivers/misc/pci_endpoint_test.c >> F: tools/pci/ > > Right, thanks, I forgot all about this separate entry. I added Lorenzo > there, resulting in the patch below. > > My practice has been that all the PCI patches (everything in > drivers/pci plus some include and x86/pci stuff) have been merged via > my tree. > > This includes things in drivers/pci/{host,dwc,endpoint,switch}, which > are non-core things and usually specific to a chipset. I try to > ensure they have individual maintainers designated, and I ask for > their acks for non-trivial changes because I have no specs and no > hardware for testing them. But I think it's still good to have one > person look over them all to try to keep some consistency across them > because they are all quite similar. > > So my hope is that Lorenzo can take over that oversight role from me, > not that he would replace any of those designated maintainers. > > Ideally, this will be transparent to patch submitters except that they > should add Lorenzo to the "To:" line (keeping linux-pci and other > interested parties). > > > commit 6b7be529634bbfbf6395f23217a66d731fbed0a0 > Author: Bjorn Helgaas <bhelgaas@google.com> > Date: Wed Nov 8 08:49:49 2017 -0600 > > MAINTAINERS: Add Lorenzo Pieralisi for PCI host bridge drivers > > Add Lorenzo Pieralisi as maintainer for PCI native host bridge drivers and > the endpoint driver framework. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > diff --git a/MAINTAINERS b/MAINTAINERS > index db412a627d96..6ce341e86fec 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10378,6 +10378,7 @@ F: drivers/pci/dwc/*keystone* > > PCI ENDPOINT SUBSYSTEM > M: Kishon Vijay Abraham I <kishon@ti.com> > +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > L: linux-pci@vger.kernel.org > T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git > S: Supported > @@ -10429,6 +10430,15 @@ F: include/linux/pci* > F: arch/x86/pci/ > F: arch/x86/kernel/quirks.c > > +PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS > +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > +L: linux-pci@vger.kernel.org > +Q: http://patchwork.ozlabs.org/project/linux-pci/list/ > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/ So, does that mean the patch(es) for host drivers shoube be based on this tree instead of yours? If yes, which tree should be preferred if a patchset wanna touch both of pci core and host drivers? > +S: Supported > +F: drivers/pci/host/ > +F: drivers/pci/dwc/ > + > PCIE DRIVER FOR AXIS ARTPEC > M: Niklas Cassel <niklas.cassel@axis.com> > M: Jesper Nilsson <jesper.nilsson@axis.com> > > >
Hi, On Thursday 09 November 2017 08:35 PM, Bjorn Helgaas wrote: > On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: >> Hi Bjorn, >> >> On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: >>> On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: >>>> From: Bjorn Helgaas <bhelgaas@google.com> >>>> >>>> Add Lorenzo Pieralisi as maintainer for PCI native host bridge drivers and >>>> the endpoint driver framework. >>>> >>>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >>> >>> This is on my for-linus branch, and I intend to merge it for v4.14. >> >> There is already an entry for PCI endpoint in MAINTAINERS file. Can Lorenzo be >> added there? >> >> PCI ENDPOINT SUBSYSTEM >> M: Kishon Vijay Abraham I <kishon@ti.com> >> L: linux-pci@vger.kernel.org >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git >> S: Supported >> F: drivers/pci/endpoint/ >> F: drivers/misc/pci_endpoint_test.c >> F: tools/pci/ > > Right, thanks, I forgot all about this separate entry. I added Lorenzo > there, resulting in the patch below. > > My practice has been that all the PCI patches (everything in > drivers/pci plus some include and x86/pci stuff) have been merged via > my tree. > > This includes things in drivers/pci/{host,dwc,endpoint,switch}, which > are non-core things and usually specific to a chipset. I try to > ensure they have individual maintainers designated, and I ask for > their acks for non-trivial changes because I have no specs and no > hardware for testing them. But I think it's still good to have one > person look over them all to try to keep some consistency across them > because they are all quite similar. > > So my hope is that Lorenzo can take over that oversight role from me, > not that he would replace any of those designated maintainers. > > Ideally, this will be transparent to patch submitters except that they > should add Lorenzo to the "To:" line (keeping linux-pci and other > interested parties). Makes sense. I'm also thinking if we should change the tree in PCI ENDPOINT SUBSYSTEM to git git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git or maybe git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/? since most of the endpoint patches also deals with modifying the controller drivers. Thanks Kishon
On Fri, Nov 10, 2017 at 08:46:29AM +0800, Shawn Lin wrote: > Hi Bjorn, > > On 2017/11/9 23:05, Bjorn Helgaas wrote: > >On Thu, Nov 09, 2017 at 11:28:36AM +0530, Kishon Vijay Abraham I wrote: > >>Hi Bjorn, > >> > >>On Thursday 09 November 2017 01:56 AM, Bjorn Helgaas wrote: > >>>On Wed, Nov 08, 2017 at 02:15:10PM -0600, Bjorn Helgaas wrote: > >>>>From: Bjorn Helgaas <bhelgaas@google.com> > >>>> > >>>>Add Lorenzo Pieralisi as maintainer for PCI native host bridge drivers and > >>>>the endpoint driver framework. > >>>> > >>>>Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > >>> > >>>This is on my for-linus branch, and I intend to merge it for v4.14. > >> > >>There is already an entry for PCI endpoint in MAINTAINERS file. Can Lorenzo be > >>added there? > >> > >>PCI ENDPOINT SUBSYSTEM > >>M: Kishon Vijay Abraham I <kishon@ti.com> > >>L: linux-pci@vger.kernel.org > >>T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git > >>S: Supported > >>F: drivers/pci/endpoint/ > >>F: drivers/misc/pci_endpoint_test.c > >>F: tools/pci/ > > > >Right, thanks, I forgot all about this separate entry. I added Lorenzo > >there, resulting in the patch below. > > > >My practice has been that all the PCI patches (everything in > >drivers/pci plus some include and x86/pci stuff) have been merged via > >my tree. > > > >This includes things in drivers/pci/{host,dwc,endpoint,switch}, which > >are non-core things and usually specific to a chipset. I try to > >ensure they have individual maintainers designated, and I ask for > >their acks for non-trivial changes because I have no specs and no > >hardware for testing them. But I think it's still good to have one > >person look over them all to try to keep some consistency across them > >because they are all quite similar. > > > >So my hope is that Lorenzo can take over that oversight role from me, > >not that he would replace any of those designated maintainers. > > > >Ideally, this will be transparent to patch submitters except that they > >should add Lorenzo to the "To:" line (keeping linux-pci and other > >interested parties). > > > > > >commit 6b7be529634bbfbf6395f23217a66d731fbed0a0 > >Author: Bjorn Helgaas <bhelgaas@google.com> > >Date: Wed Nov 8 08:49:49 2017 -0600 > > > > MAINTAINERS: Add Lorenzo Pieralisi for PCI host bridge drivers > > Add Lorenzo Pieralisi as maintainer for PCI native host bridge drivers and > > the endpoint driver framework. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > >diff --git a/MAINTAINERS b/MAINTAINERS > >index db412a627d96..6ce341e86fec 100644 > >--- a/MAINTAINERS > >+++ b/MAINTAINERS > >@@ -10378,6 +10378,7 @@ F: drivers/pci/dwc/*keystone* > > PCI ENDPOINT SUBSYSTEM > > M: Kishon Vijay Abraham I <kishon@ti.com> > >+M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > L: linux-pci@vger.kernel.org > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git > > S: Supported > >@@ -10429,6 +10430,15 @@ F: include/linux/pci* > > F: arch/x86/pci/ > > F: arch/x86/kernel/quirks.c > >+PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS > >+M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > >+L: linux-pci@vger.kernel.org > >+Q: http://patchwork.ozlabs.org/project/linux-pci/list/ > >+T: git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/ > > So, does that mean the patch(es) for host drivers shoube be based on > this tree instead of yours? If yes, which tree should be preferred if > a patchset wanna touch both of pci core and host drivers? I think you should always use Bjorn's tree as a reference and we will sort out the dependencies. Thanks, Lorenzo
On Fri, Nov 10, 2017 at 10:40:35AM +0000, Lorenzo Pieralisi wrote: > On Fri, Nov 10, 2017 at 08:46:29AM +0800, Shawn Lin wrote: > > On 2017/11/9 23:05, Bjorn Helgaas wrote: > > >diff --git a/MAINTAINERS b/MAINTAINERS > > >index db412a627d96..6ce341e86fec 100644 > > >--- a/MAINTAINERS > > >+++ b/MAINTAINERS > > >@@ -10378,6 +10378,7 @@ F: drivers/pci/dwc/*keystone* > > > PCI ENDPOINT SUBSYSTEM > > > M: Kishon Vijay Abraham I <kishon@ti.com> > > >+M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > L: linux-pci@vger.kernel.org > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git > > > S: Supported > > >@@ -10429,6 +10430,15 @@ F: include/linux/pci* > > > F: arch/x86/pci/ > > > F: arch/x86/kernel/quirks.c > > >+PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS > > >+M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > >+L: linux-pci@vger.kernel.org > > >+Q: http://patchwork.ozlabs.org/project/linux-pci/list/ > > >+T: git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/ > > > > So, does that mean the patch(es) for host drivers shoube be based on > > this tree instead of yours? If yes, which tree should be preferred if > > a patchset wanna touch both of pci core and host drivers? > > I think you should always use Bjorn's tree as a reference and we > will sort out the dependencies. Yep, that's what I think, too. My advice is to always use the "master" branch of my tree as the base. I use a lot of topic branches, and they are almost always based on my "master". There will be exceptions where that doesn't work because your patch depends on something already in my tree or something in another tree. But those are actually fairly rare, so just point that out in your cover letter and we'll sort it out on a case-by-case basis. Bjorn
diff --git a/MAINTAINERS b/MAINTAINERS index db412a627d96..6ce341e86fec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10378,6 +10378,7 @@ F: drivers/pci/dwc/*keystone* PCI ENDPOINT SUBSYSTEM M: Kishon Vijay Abraham I <kishon@ti.com> +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> L: linux-pci@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/kishon/pci-endpoint.git S: Supported @@ -10429,6 +10430,15 @@ F: include/linux/pci* F: arch/x86/pci/ F: arch/x86/kernel/quirks.c +PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS +M: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> +L: linux-pci@vger.kernel.org +Q: http://patchwork.ozlabs.org/project/linux-pci/list/ +T: git git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/ +S: Supported +F: drivers/pci/host/ +F: drivers/pci/dwc/ + PCIE DRIVER FOR AXIS ARTPEC M: Niklas Cassel <niklas.cassel@axis.com> M: Jesper Nilsson <jesper.nilsson@axis.com>