| Message ID | 36f8b5d1a32b8702941ebeda7a406188af132e9e.1310187270.git.joe@perches.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
How is this array indexed? Aren't you changing the index of the later strings? On Fri, Jul 08, 2011 at 11:20:24PM -0700, Joe Perches wrote: > Multiple quoted strings are concatenated without comma separators. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/wireless/iwlegacy/iwl4965-base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c > index 46242d2..1433466 100644 > --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c > +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c > @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = { > "NMI_INTERRUPT_DATA_ACTION_PT", > "NMI_TRM_HW_ER", > "NMI_INTERRUPT_TRM", > - "NMI_INTERRUPT_BREAK_POINT" > + "NMI_INTERRUPT_BREAK_POINT", > "DEBUG_0", > "DEBUG_1", > "DEBUG_2", > -- > 1.7.6.131.g99019 > >
On Mon, Jul 11, 2011 at 02:35:42PM -0400, John W. Linville wrote: > How is this array indexed? Aren't you changing the index of the > later strings? We read index directly from device memory (and check agains ARRAY_SIZE). Patch make indexing correct with code author intention, ACK. iwlagn should be simmilarly fine. Stanislaw > On Fri, Jul 08, 2011 at 11:20:24PM -0700, Joe Perches wrote: > > Multiple quoted strings are concatenated without comma separators. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/net/wireless/iwlegacy/iwl4965-base.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c > > index 46242d2..1433466 100644 > > --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c > > +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c > > @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = { > > "NMI_INTERRUPT_DATA_ACTION_PT", > > "NMI_TRM_HW_ER", > > "NMI_INTERRUPT_TRM", > > - "NMI_INTERRUPT_BREAK_POINT" > > + "NMI_INTERRUPT_BREAK_POINT", > > "DEBUG_0", > > "DEBUG_1", > > "DEBUG_2", > > -- > > 1.7.6.131.g99019 > > > > > > -- > John W. Linville Someday the world will need a hero, and you > linville@tuxdriver.com might be all we have. Be ready. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c index 46242d2..1433466 100644 --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = { "NMI_INTERRUPT_DATA_ACTION_PT", "NMI_TRM_HW_ER", "NMI_INTERRUPT_TRM", - "NMI_INTERRUPT_BREAK_POINT" + "NMI_INTERRUPT_BREAK_POINT", "DEBUG_0", "DEBUG_1", "DEBUG_2",
Multiple quoted strings are concatenated without comma separators. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/iwlegacy/iwl4965-base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)