diff mbox

[v4] arm64: dts: rockchip: update mipi cells for RK3399

Message ID 20171129184755.77187-1-briannorris@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Brian Norris Nov. 29, 2017, 6:47 p.m. UTC
From: Nickey Yang <nickey.yang@rock-chips.com>

We might include additional ports in derivative device trees, so the
'port' node should have an address, and the parent 'ports' node needs
/#{addres,size}-cells.

v4:
 * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
 * separate from the rest of the series, since this is mostly
   independent of the driver refactoring

Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Doug Anderson Nov. 29, 2017, 8:52 p.m. UTC | #1
Hi,

On Wed, Nov 29, 2017 at 10:47 AM, Brian Norris <briannorris@chromium.org> wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

This seems sane to me according to my current understanding and
reading of the bindings.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Heiko Stuebner Dec. 4, 2017, 10:05 a.m. UTC | #2
Am Mittwoch, 29. November 2017, 10:47:55 CET schrieb Brian Norris:
> From: Nickey Yang <nickey.yang@rock-chips.com>
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

applied for 4.16 with Doug's Review

Thanks
Heiko
Laurent Pinchart Dec. 4, 2017, 1:22 p.m. UTC | #3
Hi Nickey,

Thank you for the patch.

On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
>  		status = "disabled";
> 
>  		ports {
> -			mipi_in: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			mipi_in: port@0 {
> +				reg = <0>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;
Heiko Stuebner Dec. 4, 2017, 1:46 p.m. UTC | #4
Hi Laurent,

Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > From: Nickey Yang <nickey.yang@rock-chips.com>
> > 
> > We might include additional ports in derivative device trees, so the
> > 'port' node should have an address, and the parent 'ports' node needs
> > /#{addres,size}-cells.
> > 
> > v4:
> >  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> >  * separate from the rest of the series, since this is mostly
> >    independent of the driver refactoring
> > 
> > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

As I hadn't pushed that one yet, I've amended it with your Review-tag :-)

Thanks
Heiko
Laurent Pinchart Dec. 4, 2017, 4:36 p.m. UTC | #5
Hi Heiko,

On Monday, 4 December 2017 15:46:32 EET Heiko Stuebner wrote:
> Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> > On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > > From: Nickey Yang <nickey.yang@rock-chips.com>
> > > 
> > > We might include additional ports in derivative device trees, so the
> > > 'port' node should have an address, and the parent 'ports' node needs
> > > /#{addres,size}-cells.
> > > 
> > > v4:
> > >  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> > >  * separate from the rest of the series, since this is mostly
> > >  
> > >    independent of the driver refactoring
> > > 
> > > Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> > > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> As I hadn't pushed that one yet, I've amended it with your Review-tag :-)

Thank you :-)
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index d340b58ab184..c6dae25a3f23 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1652,7 +1652,11 @@ 
 		status = "disabled";
 
 		ports {
-			mipi_in: port {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			mipi_in: port@0 {
+				reg = <0>;
 				#address-cells = <1>;
 				#size-cells = <0>;