| Message ID | 20171202230052.34y2ivxgpgr3osct@localhost (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson <olof@lixom.net> wrote: > On Sat, Dec 02, 2017 at 01:54:41PM +0100, Christian Zigotzky wrote: >> On 02 December 2017 at 00:27AM, Bjorn Helgaas wrote: >> > >> > Thanks for testing that. I'll merge a similar patch for v4.16. >> > >> > I don't think using "pci=pcie_scan_all" is really an acceptable >> > long-term answer for you, though. Is there some way we can identify >> > at run-time whether we're on a Nemo system? If so, we can make this >> > happen automatically. >> > >> > Bjorn >> > >> Hi Bjorn, >> >> Many thanks for your effort! I appreciate it very much. :-) >> >> We can identify the Nemo board at the boot time. See dmesg output: [ >> 0.061592] NEMO SB600 IOB base e0000000 >> >> @linuxppc-dev >> Any other ideas? Maybe the same as we can identify the other P.A. Semi >> boards (Electra, Chitra, and Athena). >> >> @Olof >> Maybe you know how we can identify the P.A. Semi Nemo board at the run-time. >> >> @Darren >> Do you have an idea? > > > The below patch, together with Bjorn's, should do it. Christian, can you test > and report back? > > I'm guessing it won't do any harm to set this on non-X1000 platforms. My > test system is currently powered down so I can't check. > > > From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 > From: Olof Johansson <olof@lixom.net> > Date: Sat, 2 Dec 2017 14:56:36 -0800 > Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS > > Needed on Amiga X1000 with SB600. > > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > arch/powerpc/platforms/pasemi/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c > index 5ff6108..ea54ed2 100644 > --- a/arch/powerpc/platforms/pasemi/pci.c > +++ b/arch/powerpc/platforms/pasemi/pci.c > @@ -224,6 +224,8 @@ void __init pas_pci_init(void) > return; > } > > + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): Typo, should be ';', not ':'. I obviously didn't even try compiling this. :) -Olof
On 3. Dec 2017, at 00:02, Olof Johansson <olof@lixom.net> wrote: > >> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson <olof@lixom.net> wrote: >> >> The below patch, together with Bjorn's, should do it. Christian, can you test >> and report back? >> >> I'm guessing it won't do any harm to set this on non-X1000 platforms. My >> test system is currently powered down so I can't check. >> >> >> From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 >> From: Olof Johansson <olof@lixom.net> >> Date: Sat, 2 Dec 2017 14:56:36 -0800 >> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS >> >> Needed on Amiga X1000 with SB600. >> >> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Signed-off-by: Olof Johansson <olof@lixom.net> >> --- >> arch/powerpc/platforms/pasemi/pci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c >> index 5ff6108..ea54ed2 100644 >> --- a/arch/powerpc/platforms/pasemi/pci.c >> +++ b/arch/powerpc/platforms/pasemi/pci.c >> @@ -224,6 +224,8 @@ void __init pas_pci_init(void) >> return; >> } >> >> + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): > > Typo, should be ';', not ':'. I obviously didn't even try compiling this. :) > > > -Olof Hi Olof, Thanks a lot for your patch! I will test it on Wednesday. Cheers, Christian
Olof Johansson <olof@lixom.net> writes: > On Sat, Dec 02, 2017 at 01:54:41PM +0100, Christian Zigotzky wrote: >> On 02 December 2017 at 00:27AM, Bjorn Helgaas wrote: >> > >> > Thanks for testing that. I'll merge a similar patch for v4.16. >> > >> > I don't think using "pci=pcie_scan_all" is really an acceptable >> > long-term answer for you, though. Is there some way we can identify >> > at run-time whether we're on a Nemo system? If so, we can make this >> > happen automatically. >> > >> > Bjorn >> > >> Hi Bjorn, >> >> Many thanks for your effort! I appreciate it very much. :-) >> >> We can identify the Nemo board at the boot time. See dmesg output: [ >> 0.061592] NEMO SB600 IOB base e0000000 >> >> @linuxppc-dev >> Any other ideas? Maybe the same as we can identify the other P.A. Semi >> boards (Electra, Chitra, and Athena). >> >> @Olof >> Maybe you know how we can identify the P.A. Semi Nemo board at the run-time. >> >> @Darren >> Do you have an idea? > > > The below patch, together with Bjorn's, should do it. Christian, can you test > and report back? > > I'm guessing it won't do any harm to set this on non-X1000 platforms. My > test system is currently powered down so I can't check. My pasemi board had been powered off for a while and when I turned it back on something popped, the power supply blew up and tripped a breaker. So I also can't test this, at least for now, until I get my "allowed to use hardware" license back from my colleagues in the office. cheers
On Wed, Dec 6, 2017 at 4:44 AM, Michael Ellerman <mpe@ellerman.id.au> wrote: > Olof Johansson <olof@lixom.net> writes: > >> On Sat, Dec 02, 2017 at 01:54:41PM +0100, Christian Zigotzky wrote: >>> On 02 December 2017 at 00:27AM, Bjorn Helgaas wrote: >>> > >>> > Thanks for testing that. I'll merge a similar patch for v4.16. >>> > >>> > I don't think using "pci=pcie_scan_all" is really an acceptable >>> > long-term answer for you, though. Is there some way we can identify >>> > at run-time whether we're on a Nemo system? If so, we can make this >>> > happen automatically. >>> > >>> > Bjorn >>> > >>> Hi Bjorn, >>> >>> Many thanks for your effort! I appreciate it very much. :-) >>> >>> We can identify the Nemo board at the boot time. See dmesg output: [ >>> 0.061592] NEMO SB600 IOB base e0000000 >>> >>> @linuxppc-dev >>> Any other ideas? Maybe the same as we can identify the other P.A. Semi >>> boards (Electra, Chitra, and Athena). >>> >>> @Olof >>> Maybe you know how we can identify the P.A. Semi Nemo board at the run-time. >>> >>> @Darren >>> Do you have an idea? >> >> >> The below patch, together with Bjorn's, should do it. Christian, can you test >> and report back? >> >> I'm guessing it won't do any harm to set this on non-X1000 platforms. My >> test system is currently powered down so I can't check. > > My pasemi board had been powered off for a while and when I turned it > back on something popped, the power supply blew up and tripped a > breaker. > > So I also can't test this, at least for now, until I get my "allowed to > use hardware" license back from my colleagues in the office. Ouch. Sounds like it's the PSU not the board. Hopefully there was no board damage, let me know if you need a replacement though and I'll see what I can find. -Olof
Olof Johansson <olof@lixom.net> writes: > On Wed, Dec 6, 2017 at 4:44 AM, Michael Ellerman <mpe@ellerman.id.au> wrote: >> Olof Johansson <olof@lixom.net> writes: >>> >>> The below patch, together with Bjorn's, should do it. Christian, can you test >>> and report back? >>> >>> I'm guessing it won't do any harm to set this on non-X1000 platforms. My >>> test system is currently powered down so I can't check. >> >> My pasemi board had been powered off for a while and when I turned it >> back on something popped, the power supply blew up and tripped a >> breaker. >> >> So I also can't test this, at least for now, until I get my "allowed to >> use hardware" license back from my colleagues in the office. > > Ouch. Sounds like it's the PSU not the board. Hopefully there was no > board damage, let me know if you need a replacement though and I'll > see what I can find. Thanks. Yeah the power supply is toast. One of the guys is going to see if he can fix it. Will try and get the board going, will let you know if it's dead too. cheers
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 5ff6108..ea54ed2 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -224,6 +224,8 @@ void __init pas_pci_init(void) return; } + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): + for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) of_node_get(np);