diff mbox

[i-g-t] meson: use message() rather than warning()

Message ID 20180104202936.31704-1-lucas.demarchi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas De Marchi Jan. 4, 2018, 8:29 p.m. UTC
warning() was only added to the meson interpreter in 0.44 which is
currently the last version. Let's use message() as we are currently
requiring meson > 0.40. Otherwise we get the following error:

	Meson encountered an error in file overlay/meson.build, line 62, column 1:
	Unknown function "warning".

Fixes: 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location")
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rhys Kidd <rhyskidd@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 overlay/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rhys Kidd Jan. 4, 2018, 9:14 p.m. UTC | #1
On 4 January 2018 at 15:29, Lucas De Marchi <lucas.demarchi@intel.com>
wrote:

> warning() was only added to the meson interpreter in 0.44 which is
> currently the last version. Let's use message() as we are currently
> requiring meson > 0.40. Otherwise we get the following error:
>
>         Meson encountered an error in file overlay/meson.build, line 62,
> column 1:
>         Unknown function "warning".
>
> Fixes: 865a47ca ("overlay: parse tracepoints from sysfs to figure out
> fields' location")
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>

Reviewed-by: Rhys Kidd <rhyskidd@gmail.com>


> Cc: Rhys Kidd <rhyskidd@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  overlay/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/overlay/meson.build b/overlay/meson.build
> index 8b5c52b4..546c8377 100644
> --- a/overlay/meson.build
> +++ b/overlay/meson.build
> @@ -59,7 +59,7 @@ if leg.found()
>                 command: [leg, '-P', '-o', '@OUTPUT@', '@INPUT@'])
>         gpu_overlay_src += leg_file
>  else
> -       warning('leg command not found, disabling overlay; try : apt-get
> install peg')
> +       message('WARNING: leg command not found, disabling overlay; try :
> apt-get install peg')
>  endif
>
>  if leg.found() and xrandr.found() and cairo.found()
> --
> 2.14.3
>
>
diff mbox

Patch

diff --git a/overlay/meson.build b/overlay/meson.build
index 8b5c52b4..546c8377 100644
--- a/overlay/meson.build
+++ b/overlay/meson.build
@@ -59,7 +59,7 @@  if leg.found()
 		command: [leg, '-P', '-o', '@OUTPUT@', '@INPUT@'])
 	gpu_overlay_src += leg_file
 else
-	warning('leg command not found, disabling overlay; try : apt-get install peg')
+	message('WARNING: leg command not found, disabling overlay; try : apt-get install peg')
 endif
 
 if leg.found() and xrandr.found() and cairo.found()