| Message ID | 6FA0216CBF61AE4AA9DA6744243E7853DB5C4578@jtjnmailbox06.home.langchao.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
On Mon, 2018-01-29 at 06:04 +0000, Tom Geng(耿芳忠) wrote: > Hi, Xose, > I sent the patch to dm-devel last week, but forgot to CC you. Please > help to > review and have chance to submit to the mainline. > Thank you a lot. > > > > From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 > > 2001 > > From: Tom Geng <gengfangzhong@inspur.com> > Date: Tue, 23 Jan 2018 15:33:09 +0800 > Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table > > --- > libmultipath/hwtable.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 448effe3..93d67df0 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = { > .pgpolicy = MULTIBUS, > .no_path_retry = 30, > }, > + /* > + * INSPUR > + */ > + { > + /* AS5300/AS5500 G2 */ > + .vendor = "INSPUR", > + .product = "MCS", > + .pgpolicy = GROUP_BY_PRIO, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .prio_name = PRIO_ALUA, > + }, > /* > * EOL > */ multipath-tools default to .pgpolicy = failover. Please confirm that this is really your intention. Martin
Hi, Martin, .pgfailback = -FAILBACK_IMMEDIATE is OK for INSPUR/MCS in ALUA mode. We have tested failback function, the device controller works well. Thank you a lot. -----Original Message----- From: Martin Wilck [mailto:mwilck@suse.com] Sent: Monday, January 29, 2018 9:38 PM To: Tom Geng(耿芳忠) <gengfangzhong@inspur.com>; xose.vazquez@gmail.com Cc: dm-devel@redhat.com Subject: Re: [dm-devel] multipath-tools: add INSPUR/MCS to hardware table On Mon, 2018-01-29 at 06:04 +0000, Tom Geng(耿芳忠) wrote: > Hi, Xose, > I sent the patch to dm-devel last week, but forgot to CC you. Please > help to review and have chance to submit to the mainline. > Thank you a lot. > > > > From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 > > 2001 > > From: Tom Geng <gengfangzhong@inspur.com> > Date: Tue, 23 Jan 2018 15:33:09 +0800 > Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table > > --- > libmultipath/hwtable.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index > 448effe3..93d67df0 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = { > .pgpolicy = MULTIBUS, > .no_path_retry = 30, > }, > + /* > + * INSPUR > + */ > + { > + /* AS5300/AS5500 G2 */ > + .vendor = "INSPUR", > + .product = "MCS", > + .pgpolicy = GROUP_BY_PRIO, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .prio_name = PRIO_ALUA, > + }, > /* > * EOL > */ multipath-tools default to .pgpolicy = failover. Please confirm that this is really your intention. Martin -- Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Tue, 2018-01-30 at 01:54 +0000, Tom Geng(耿芳忠) wrote: > Hi, Martin, > .pgfailback = -FAILBACK_IMMEDIATE is OK for INSPUR/MCS in ALUA > mode. We have tested failback function, the device controller works > well. > Thank you a lot. That's not what I meant. ".pgfailback" controls what happens if a once lost path comes back online. ".pgpolicy" controls how the load is distributed over healthy paths. The default .pgpolicy = failover means that you'll only ever have one "running" path at any time (iow, no load balancing). I asked you to confirm that that's what you need. Martin > > > > -----Original Message----- > From: Martin Wilck [mailto:mwilck@suse.com] > Sent: Monday, January 29, 2018 9:38 PM > To: Tom Geng(耿芳忠) <gengfangzhong@inspur.com>; xose.vazquez@gmail.com > Cc: dm-devel@redhat.com > Subject: Re: [dm-devel] multipath-tools: add INSPUR/MCS to hardware > table > > On Mon, 2018-01-29 at 06:04 +0000, Tom Geng(耿芳忠) wrote: > > Hi, Xose, > > I sent the patch to dm-devel last week, but forgot to CC you. > > Please > > help to review and have chance to submit to the mainline. > > Thank you a lot. > > > > > > > From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 > > > 2001 > > > > From: Tom Geng <gengfangzhong@inspur.com> > > Date: Tue, 23 Jan 2018 15:33:09 +0800 > > Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table > > > > --- > > libmultipath/hwtable.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index > > 448effe3..93d67df0 100644 > > --- a/libmultipath/hwtable.c > > +++ b/libmultipath/hwtable.c > > @@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = { > > .pgpolicy = MULTIBUS, > > .no_path_retry = 30, > > }, > > + /* > > + * INSPUR > > + */ > > + { > > + /* AS5300/AS5500 G2 */ > > + .vendor = "INSPUR", > > + .product = "MCS", > > + .pgpolicy = GROUP_BY_PRIO, > > + .pgfailback = -FAILBACK_IMMEDIATE, > > + .prio_name = PRIO_ALUA, > > + }, > > /* > > * EOL > > */ > > multipath-tools default to .pgpolicy = failover. Please confirm that > this is really your intention. > > Martin > > -- > Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107 SUSE > Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB > 21284 (AG Nürnberg) >
On 01/29/2018 02:37 PM, Martin Wilck wrote: > On Mon, 2018-01-29 at 06:04 +0000, Tom Geng(耿芳忠) wrote: >> + /* >> + * INSPUR >> + */ >> + { >> + /* AS5300/AS5500 G2 */ >> + .vendor = "INSPUR", >> + .product = "MCS", >> + .pgpolicy = GROUP_BY_PRIO, ^^^^^^^^ ^^^^^^^^^^^^^ >> + .pgfailback = -FAILBACK_IMMEDIATE, >> + .prio_name = PRIO_ALUA, >> + }, > multipath-tools default to .pgpolicy = failover. Please confirm that > this is really your intention. It was set as GROUP_BY_PRIO, with PRIO_ALUA as prio. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Tue, 2018-01-30 at 14:58 +0100, Xose Vazquez Perez wrote: > On 01/29/2018 02:37 PM, Martin Wilck wrote: > > > On Mon, 2018-01-29 at 06:04 +0000, Tom Geng(耿芳忠) wrote: > > > + /* > > > + * INSPUR > > > + */ > > > + { > > > + /* AS5300/AS5500 G2 */ > > > + .vendor = "INSPUR", > > > + .product = "MCS", > > > + .pgpolicy = GROUP_BY_PRIO, > > ^^^^^^^^ ^^^^^^^^^^^^^ > > > > + .pgfailback = -FAILBACK_IMMEDIATE, > > > + .prio_name = PRIO_ALUA, > > > + }, > > multipath-tools default to .pgpolicy = failover. Please confirm > > that > > this is really your intention. > > It was set as GROUP_BY_PRIO, with PRIO_ALUA as prio. Argh. Obvious case of brain malfunction on my part. Sorry, everyone. Martin
On 01/29/2018 07:04 AM, Tom Geng(耿芳忠) wrote: > I sent the patch to dm-devel last week, but forgot to CC you. Please help to > review and have chance to submit to the mainline. In the original patch a maintainer was included, other than that: Reviewed-by: Xose Vazquez Perez <xose.vazquez@gmail.com> >>From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 2001 > From: Tom Geng <gengfangzhong@inspur.com> > Date: Tue, 23 Jan 2018 15:33:09 +0800 > Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table > > --- > libmultipath/hwtable.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 448effe3..93d67df0 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = { > .pgpolicy = MULTIBUS, > .no_path_retry = 30, > }, > + /* > + * INSPUR > + */ > + { > + /* AS5300/AS5500 G2 */ > + .vendor = "INSPUR", > + .product = "MCS", > + .pgpolicy = GROUP_BY_PRIO, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .prio_name = PRIO_ALUA, > + }, > /* > * EOL > */ > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 448effe3..93d67df0 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, .no_path_retry = 30, }, + /* + * INSPUR + */ + { + /* AS5300/AS5500 G2 */ + .vendor = "INSPUR", + .product = "MCS", + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .prio_name = PRIO_ALUA, + }, /* * EOL */