diff mbox

dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl

Message ID 1519384260-23875-1-git-send-email-fabrice.gasnier@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabrice Gasnier Feb. 23, 2018, 11:11 a.m. UTC
- Add missing pinctrl description. Support is made optional as dfsdm
  may use internal sources (e.g. via registers)
- Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
Basically, this should be "falling edge = logic 0", not "1" that applies
to "MANCH_R".
BTW, make the description complete by describing both rising/falling
edges as described in reference manuals.

Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
 Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Arnaud POULIQUEN Feb. 23, 2018, 1:47 p.m. UTC | #1
Hello,

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Regards,
Arnaud

On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> - Add missing pinctrl description. Support is made optional as dfsdm
>   may use internal sources (e.g. via registers)
> - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> Basically, this should be "falling edge = logic 0", not "1" that applies
> to "MANCH_R".
> BTW, make the description complete by describing both rising/falling
> edges as described in reference manuals.
> 
> Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> index 911492da..ed7520d 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> @@ -32,6 +32,10 @@ Optional properties:
>  		  to "clock" property. Frequency must be a multiple of the rcc
>  		  clock frequency. If not, SPI CLKOUT frequency will not be
>  		  accurate.
> +- pinctrl-names:	Set to "default".
> +- pinctrl-0:		List of phandles pointing to pin configuration
> +			nodes to set pins in mode of operation for dfsdm
> +			on external pin.
>  
>  Contents of a STM32 DFSDM child nodes:
>  --------------------------------------
> @@ -68,8 +72,8 @@ Optional properties:
>  - st,adc-channel-types:	Single-ended channel input type.
>  			- "SPI_R": SPI with data on rising edge (default)
>  			- "SPI_F": SPI with data on falling edge
> -			- "MANCH_R": manchester codec, rising edge = logic 0
> -			- "MANCH_F": manchester codec, falling edge = logic 1
> +			- "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> +			- "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
>  - st,adc-channel-clk-src: Conversion clock source.
>  			  - "CLKIN": external SPI clock (CLKIN x)
>  			  - "CLKOUT": internal SPI clock (CLKOUT) (default)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Feb. 24, 2018, 1:11 p.m. UTC | #2
On Fri, 23 Feb 2018 14:47:36 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:

> Hello,
> 
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

I'm feeling conservative today so will be wanting a devicetree
maintainer ack for this one..

Jonathan

> 
> Regards,
> Arnaud
> 
> On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> >   may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> > 
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> > 
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > index 911492da..ed7520d 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > @@ -32,6 +32,10 @@ Optional properties:
> >  		  to "clock" property. Frequency must be a multiple of the rcc
> >  		  clock frequency. If not, SPI CLKOUT frequency will not be
> >  		  accurate.
> > +- pinctrl-names:	Set to "default".
> > +- pinctrl-0:		List of phandles pointing to pin configuration
> > +			nodes to set pins in mode of operation for dfsdm
> > +			on external pin.
> >  
> >  Contents of a STM32 DFSDM child nodes:
> >  --------------------------------------
> > @@ -68,8 +72,8 @@ Optional properties:
> >  - st,adc-channel-types:	Single-ended channel input type.
> >  			- "SPI_R": SPI with data on rising edge (default)
> >  			- "SPI_F": SPI with data on falling edge
> > -			- "MANCH_R": manchester codec, rising edge = logic 0
> > -			- "MANCH_F": manchester codec, falling edge = logic 1
> > +			- "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> > +			- "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
> >  - st,adc-channel-clk-src: Conversion clock source.
> >  			  - "CLKIN": external SPI clock (CLKIN x)
> >  			  - "CLKOUT": internal SPI clock (CLKOUT) (default)
> >   

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring (Arm) March 2, 2018, 4:25 p.m. UTC | #3
On Fri, Feb 23, 2018 at 12:11:00PM +0100, Fabrice Gasnier wrote:
> - Add missing pinctrl description. Support is made optional as dfsdm
>   may use internal sources (e.g. via registers)
> - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> Basically, this should be "falling edge = logic 0", not "1" that applies
> to "MANCH_R".
> BTW, make the description complete by describing both rising/falling
> edges as described in reference manuals.
> 
> Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron March 3, 2018, 3:08 p.m. UTC | #4
On Fri, 2 Mar 2018 10:25:13 -0600
Rob Herring <robh@kernel.org> wrote:

> On Fri, Feb 23, 2018 at 12:11:00PM +0100, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> >   may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> > 
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> > 
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)  
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
index 911492da..ed7520d 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
@@ -32,6 +32,10 @@  Optional properties:
 		  to "clock" property. Frequency must be a multiple of the rcc
 		  clock frequency. If not, SPI CLKOUT frequency will not be
 		  accurate.
+- pinctrl-names:	Set to "default".
+- pinctrl-0:		List of phandles pointing to pin configuration
+			nodes to set pins in mode of operation for dfsdm
+			on external pin.
 
 Contents of a STM32 DFSDM child nodes:
 --------------------------------------
@@ -68,8 +72,8 @@  Optional properties:
 - st,adc-channel-types:	Single-ended channel input type.
 			- "SPI_R": SPI with data on rising edge (default)
 			- "SPI_F": SPI with data on falling edge
-			- "MANCH_R": manchester codec, rising edge = logic 0
-			- "MANCH_F": manchester codec, falling edge = logic 1
+			- "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
+			- "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
 - st,adc-channel-clk-src: Conversion clock source.
 			  - "CLKIN": external SPI clock (CLKIN x)
 			  - "CLKOUT": internal SPI clock (CLKOUT) (default)