| Message ID | 1520490204-10411-1-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a24853aab59184ebd19c5e078c7b29e1c316e3a1 |
| Delegated to: | Kalle Valo |
| Headers | show |
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Patch applied to wireless-drivers-next.git, thanks. a24853aab591 ssb: use put_device() if device_register fail
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..e732fd3 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -522,7 +522,7 @@ static int ssb_devices_register(struct ssb_bus *bus) /* Set dev to NULL to not unregister * dev on error unwinding. */ sdev->dev = NULL; - kfree(devwrap); + put_device(dev); goto error; } dev_idx++;
Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Removed kfree() call for @dev. changes in v3: Add put_device() in place of kfree(). drivers/ssb/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)