| Message ID | 87tvtbg0i9.fsf@concordia.ellerman.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Michael, Thanks for the hint because of removing tags and thanks a lot for adding the patch to the official source code. This patch helps us a lot. Have a nice day! Christian On 19 March 2018 at 11:32PM, Michael Ellerman wrote: > > I'm happy to take it, I've been meaning to check if Olof sent a SOB in > his original mail but haven't got to it. > > ... > > Yes, he did, see below. > > So I'll merge that, I'll add a Tested-by for you Christian. > > Christian please don't remove any of the tags when submitting other > peoples' patches in future. > > cheers > > > >From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 > From: Olof Johansson <olof@lixom.net> > Date: Sat, 2 Dec 2017 14:56:36 -0800 > Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS > > Needed on Amiga X1000 with SB600. > > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > arch/powerpc/platforms/pasemi/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c > index 5ff6108..ea54ed2 100644 > --- a/arch/powerpc/platforms/pasemi/pci.c > +++ b/arch/powerpc/platforms/pasemi/pci.c > @@ -224,6 +224,8 @@ void __init pas_pci_init(void) > return; > } > > + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): > + > for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) > if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) > of_node_get(np); >
Hello Michael On 20/03/2018, Michael Ellerman wrote: >> The patch looks fine, but I need a signed-off-by line before I can apply >> it. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst > > I'm happy to take it, I've been meaning to check if Olof sent a SOB in > his original mail but haven't got to it. If thats the way you want to go... We still have an out-of-tree patch we need to apply, which I think is the right place for this. In fact I submitted some patches at the end of last year with a cleaned up version (including the above patch). Here are links: https://patchwork.ozlabs.org/patch/854270/ https://patchwork.ozlabs.org/patch/854269/ https://patchwork.ozlabs.org/patch/854271/ https://patchwork.ozlabs.org/patch/854268/ These seem to have been missed somehow. (I intended them for 4.16) If these are suitable, the only thing left would be the pasemi i2c bus patch, which keeps getting ignored by the i2c guys. Regards Darren
Hi Michael, Many thanks for your help. Did you merge Olof‘s patch? I still have to patch the 4.17 source code. Thanks, Christian Sent from my iPhone > On 19. Mar 2018, at 23:32, Michael Ellerman <mpe@ellerman.id.au> wrote: > > Bjorn Helgaas <helgaas@kernel.org> writes: > >>> On Fri, Mar 16, 2018 at 01:55:36PM +0100, Christian Zigotzky wrote: >>> Bjorn Helgaas created a patch for making PCI_SCAN_ALL_PCIE_DEVS work for >>> Root Ports as well as Downstream. Previously PCI_SCAN_ALL_PCIE_DEVS (set by >>> quirks or the "pci=pcie_scan_all" >>> kernel parameter) only affected Switch Downstream Ports, not Root Ports. The >>> problem is, that we have to add always the boot argument "pci=pcie_scan_all" >>> for using Bjorn's improvements. Without the boot argument >>> "pci=pcie_scan_all", the kernel doesn't boot on P.A. Semi boards with SB600 >>> chipset (SB600 chipset is connected via PCIe x4 to the P.A. Semi’s >>> PA6T-1682M System-on-a-Chip) because the kernel can't find any drives >>> connected to the SB600 anymore. Olof Johansson has created a patch for >>> executing "pci=pcie_scan_all" automatically on P.A. Semi boards. With his >>> patch, we don't need to add 'pci=pcie_scan_all' to the kernel boot arguments >>> anymore. >> >> The patch looks fine, but I need a signed-off-by line before I can apply >> it. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst > > I'm happy to take it, I've been meaning to check if Olof sent a SOB in > his original mail but haven't got to it. > > ... > > Yes, he did, see below. > > So I'll merge that, I'll add a Tested-by for you Christian. > > Christian please don't remove any of the tags when submitting other > peoples' patches in future. > > cheers > > > From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 > From: Olof Johansson <olof@lixom.net> > Date: Sat, 2 Dec 2017 14:56:36 -0800 > Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS > > Needed on Amiga X1000 with SB600. > > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Signed-off-by: Olof Johansson <olof@lixom.net> > --- > arch/powerpc/platforms/pasemi/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c > index 5ff6108..ea54ed2 100644 > --- a/arch/powerpc/platforms/pasemi/pci.c > +++ b/arch/powerpc/platforms/pasemi/pci.c > @@ -224,6 +224,8 @@ void __init pas_pci_init(void) > return; > } > > + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): > + > for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) > if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) > of_node_get(np);
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 5ff6108..ea54ed2 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -224,6 +224,8 @@ void __init pas_pci_init(void) return; } + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): + for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) of_node_get(np);