diff mbox

[PATCHV2,1/5] OMAP: I2C: Add a device reset field to platform data

Message ID 1311246554-22975-2-git-send-email-shubhrajyoti@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shubhrajyoti Datta July 21, 2011, 11:09 a.m. UTC
Under some conditions the driver may want to do a reset
of the device. Adding a reset field  to the platform
data.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 include/linux/i2c-omap.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Santosh Shilimkar July 21, 2011, 11:18 a.m. UTC | #1
Shubro,

On 7/21/2011 4:39 PM, Shubhrajyoti D wrote:
> Under some conditions the driver may want to do a reset
> of the device. Adding a reset field  to the platform
> data.
>
> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
> ---
>   include/linux/i2c-omap.h |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/i2c-omap.h b/include/linux/i2c-omap.h
> index 98ae49b..8aa91b6 100644
> --- a/include/linux/i2c-omap.h
> +++ b/include/linux/i2c-omap.h
> @@ -38,6 +38,7 @@ struct omap_i2c_bus_platform_data {
>   	int		(*device_enable) (struct platform_device *pdev);
>   	int		(*device_shutdown) (struct platform_device *pdev);
>   	int		(*device_idle) (struct platform_device *pdev);
> +	int		(*device_reset) (struct device *dev);
Any reason you haven't clubbed this with the omap i2c reset
implementation patch ?
Since i2c-omap.h isn't a generic header file and specific
to omap i2c drive, you could combine 1/5 and 2/5
diff mbox

Patch

diff --git a/include/linux/i2c-omap.h b/include/linux/i2c-omap.h
index 98ae49b..8aa91b6 100644
--- a/include/linux/i2c-omap.h
+++ b/include/linux/i2c-omap.h
@@ -38,6 +38,7 @@  struct omap_i2c_bus_platform_data {
 	int		(*device_enable) (struct platform_device *pdev);
 	int		(*device_shutdown) (struct platform_device *pdev);
 	int		(*device_idle) (struct platform_device *pdev);
+	int		(*device_reset) (struct device *dev);
 };
 
 #endif