diff mbox

display: panel: Add KOE tx14d24vm1bpa display support (320x240)

Message ID 20180412143715.6828-1-lukma@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lukasz Majewski April 12, 2018, 2:37 p.m. UTC 
This commit adds support for KOE's 5.7" display.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Comments

Rob Herring (Arm) April 16, 2018, 7:24 p.m. UTC | #1 
On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
> This commit adds support for KOE's 5.7" display.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42 ++++++++++++++++++++++
>  drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt

Reviewed-by: Rob Herring <robh@kernel.org>
Lukasz Majewski May 4, 2018, 10:28 a.m. UTC | #2 
Hi Rob,

> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
> > This commit adds support for KOE's 5.7" display.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42
> > ++++++++++++++++++++++
> > drivers/gpu/drm/panel/panel-simple.c               | 26
> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt  
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

Gentle ping on this - as I don't know if this patch been applied.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Rob Herring (Arm) May 10, 2018, 2:22 p.m. UTC | #3 
On Fri, May 4, 2018 at 5:28 AM, Lukasz Majewski <lukma@denx.de> wrote:
> Hi Rob,
>
>> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:
>> > This commit adds support for KOE's 5.7" display.
>> >
>> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
>> > ---
>> >  .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42
>> > ++++++++++++++++++++++
>> > drivers/gpu/drm/panel/panel-simple.c               | 26
>> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644
>> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>
> Gentle ping on this - as I don't know if this patch been applied.

This should go thru DRM tree via Thierry.

Rob
Lukasz Majewski May 11, 2018, 3:04 p.m. UTC | #4 
Hi Rob, Thierry

> On Fri, May 4, 2018 at 5:28 AM, Lukasz Majewski <lukma@denx.de> wrote:
> > Hi Rob,
> >  
> >> On Thu, Apr 12, 2018 at 04:37:15PM +0200, Lukasz Majewski wrote:  
> >> > This commit adds support for KOE's 5.7" display.
> >> >
> >> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> >> > ---
> >> >  .../bindings/display/panel/koe,tx14d24vm1bpa.txt   | 42
> >> > ++++++++++++++++++++++
> >> > drivers/gpu/drm/panel/panel-simple.c               | 26
> >> > ++++++++++++++ 2 files changed, 68 insertions(+) create mode
> >> > 100644
> >> > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt  
> >>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >>  
> >
> > Gentle ping on this - as I don't know if this patch been applied.  
> 
> This should go thru DRM tree via Thierry.

Would it be possible to pull this patch along with:
[PATCH v3] display: panel: Add AUO g070vvn01 display support (800x480)

To your -next tree (as we are now with -rc4) ?

> 
> Rob


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
new file mode 100644
index 000000000000..be7ac666807b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt
@@ -0,0 +1,42 @@ 
+Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel
+
+Required properties:
+- compatible: should be "koe,tx14d24vm1bpa"
+- backlight: phandle of the backlight device attached to the panel
+- power-supply: single regulator to provide the supply voltage
+
+Required nodes:
+- port: Parallel port mapping to connect this display
+
+This panel needs single power supply voltage. Its backlight is conntrolled
+via PWM signal.
+
+Example:
+--------
+
+Example device-tree definition when connected to iMX53 based board
+
+	lcd_panel: lcd-panel {
+		compatible = "koe,tx14d24vm1bpa";
+		backlight = <&backlight_lcd>;
+		power-supply = <&reg_3v3>;
+
+		port {
+			lcd_panel_in: endpoint {
+				remote-endpoint = <&lcd_display_out>;
+			};
+		};
+	};
+
+Then one needs to extend the dispX node:
+
+	lcd_display: disp1 {
+
+		port@1 {
+			reg = <1>;
+
+			lcd_display_out: endpoint {
+				remote-endpoint = <&lcd_panel_in>;
+			};
+		};
+	};
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 62314085b635..45e61af936e0 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1245,6 +1245,29 @@  static const struct panel_desc innolux_zj070na_01p = {
 	},
 };
 
+static const struct display_timing koe_tx14d24vm1bpa_timing = {
+	.pixelclock = { 5580000, 5850000, 6200000 },
+	.hactive = { 320, 320, 320 },
+	.hfront_porch = { 30, 30, 30 },
+	.hback_porch = { 30, 30, 30 },
+	.hsync_len = { 1, 5, 17 },
+	.vactive = { 240, 240, 240 },
+	.vfront_porch = { 6, 6, 6 },
+	.vback_porch = { 5, 5, 5 },
+	.vsync_len = { 1, 2, 11 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx14d24vm1bpa = {
+	.timings = &koe_tx14d24vm1bpa_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 115,
+		.height = 86,
+	},
+};
+
 static const struct display_timing kyo_tcg121xglp_timing = {
 	.pixelclock = { 52000000, 65000000, 71000000 },
 	.hactive = { 1024, 1024, 1024 },
@@ -2155,6 +2178,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "innolux,zj070na-01p",
 		.data = &innolux_zj070na_01p,
 	}, {
+		.compatible = "koe,tx14d24vm1bpa",
+		.data = &koe_tx14d24vm1bpa,
+	}, {
 		.compatible = "kyo,tcg121xglp",
 		.data = &kyo_tcg121xglp,
 	}, {