| Message ID | 20180430194520.9065-2-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2018/04/30 12:45, Luis R. Rodriguez wrote: > The target type should be "zoned", not "dm-zoned". > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > The README does note explain if one should use dmzadm to format a drive > if using dm zone or only if one is to use a filesystem which supports > zones, such as f2fs. Or if we should *always* use dmzadm format regardless > of the circumstance. dmzadm is only for dm-zoned device mapper. If the file system natively support zoned block devices, it is the FS problem to format the drive accordingly to ZBC/ZAC constraints. And for these files systems, dm-zoned is useless. > Could this be clarfied? What are the downsides to not using dmzadm > format on a drive and say a user just going straight to use the dm zone > and then mkfs on top of it? OK. I will look into it and clarify. > > diff --git a/README b/README > index 7762694..9aea28e 100644 > --- a/README > +++ b/README > @@ -184,7 +184,7 @@ options="$@" > > modprobe dm-zoned > > -echo "0 `blockdev --getsize ${dev}` dm-zoned ${dev} ${options}" | \ > +echo "0 `blockdev --getsize ${dev}` zoned ${dev} ${options}" | \ > dmsetup create zoned-`basename ${dev}` > ]] Yes, indeed... Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com> -- Damien Le Moal Western Digital Research
On Mon, Apr 30, 2018 at 08:36:09PM +0000, Damien Le Moal wrote: > On 2018/04/30 12:45, Luis R. Rodriguez wrote: > > The target type should be "zoned", not "dm-zoned". > > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > > --- > > README | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > The README does note explain if one should use dmzadm to format a drive > > if using dm zone or only if one is to use a filesystem which supports > > zones, such as f2fs. Or if we should *always* use dmzadm format regardless > > of the circumstance. > > dmzadm is only for dm-zoned device mapper. If the file system natively support > zoned block devices, it is the FS problem to format the drive accordingly to > ZBC/ZAC constraints. The README could be update to reflect this then, just to be sure. Only now that I realize it has the dm prefix did I realize this was an obvious requirement :P > And for these files systems, dm-zoned is useless. Sure, make sense. Luis
diff --git a/README b/README index 7762694..9aea28e 100644 --- a/README +++ b/README @@ -184,7 +184,7 @@ options="$@" modprobe dm-zoned -echo "0 `blockdev --getsize ${dev}` dm-zoned ${dev} ${options}" | \ +echo "0 `blockdev --getsize ${dev}` zoned ${dev} ${options}" | \ dmsetup create zoned-`basename ${dev}` ]]
The target type should be "zoned", not "dm-zoned". Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The README does note explain if one should use dmzadm to format a drive if using dm zone or only if one is to use a filesystem which supports zones, such as f2fs. Or if we should *always* use dmzadm format regardless of the circumstance. Could this be clarfied? What are the downsides to not using dmzadm format on a drive and say a user just going straight to use the dm zone and then mkfs on top of it?